spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Tech debt] SonarQube S2368: public method exposes jagged/multidimensional array (TrailGeometry) #248

New Issue
Closed
opened 2026-06-19 18:45:00 +00:00 by spikerj · 1 comment
spikerj commented 2026-06-19 18:45:00 +00:00
Owner
Copy Link
Copy Source

Surfaced by SonarQube (api.spikersoft.com), rule csharpsquid:S2368, severity BLOCKER (MAINTAINABILITY). Public APIs taking multidimensional/jagged arrays are error-prone and hard to consume.

Locations

  • SpikerSoft.Data/Mongos/Map/Trail/TrailGeometry.cs:25
  • SpikerSoft.Data/Mongos/Map/Trail/TrailGeometry.cs:34

Fix

Make the method private, or replace the jagged/multidim parameter with a clearer type (e.g. a collection of a small struct/record, or a flattened representation with explicit dimensions).

Rule: https://rules.sonarsource.com/csharp/RSPEC-2368/

Surfaced by SonarQube (`api.spikersoft.com`), rule `csharpsquid:S2368`, severity BLOCKER (MAINTAINABILITY). Public APIs taking multidimensional/jagged arrays are error-prone and hard to consume. ## Locations - `SpikerSoft.Data/Mongos/Map/Trail/TrailGeometry.cs:25` - `SpikerSoft.Data/Mongos/Map/Trail/TrailGeometry.cs:34` ## Fix Make the method `private`, or replace the jagged/multidim parameter with a clearer type (e.g. a collection of a small struct/record, or a flattened representation with explicit dimensions). _Rule: https://rules.sonarsource.com/csharp/RSPEC-2368/_
spikerj added the sonarqube label 2026-06-19 18:45:00 +00:00
spikerj commented 2026-06-20 02:03:30 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #12 (merged to master). TrailGeometry.Create/CreateMultiLine params changed from jagged arrays to IReadOnlyList<...>; the 3 call sites use collection-expression literals so no caller changes were needed. Closing.

Resolved in spikersoft-backend PR #12 (merged to `master`). `TrailGeometry.Create`/`CreateMultiLine` params changed from jagged arrays to `IReadOnlyList<...>`; the 3 call sites use collection-expression literals so no caller changes were needed. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels sonarqube
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#248