spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

/blog crashes with uncaught exception when the posts API is unreachable #310

New Issue
Closed
opened 2026-07-01 20:45:50 +00:00 by spikerj · 2 comments
spikerj commented 2026-07-01 20:45:50 +00:00
Owner
Copy Link
Copy Source

Found by the E2E anonymous walk (epic #307) after hardening the shell-mount assertion.

Symptom

When GET /api/blog/posts fails (API down, network error, CORS), /blog throws an uncaught client-side exception ([pageerror] k minified) instead of showing the error/retry UI.

Root cause

BlogListComponent.loadBlogPosts() calls this.blogService.getAllBlogPosts().subscribe() with no error handler. The service's tap({ error }) records the failure in its errorSignal (which drives the retry UI) but does not swallow it — so RxJS rethrows the error from the bare .subscribe() as an unhandled exception.

libraries/features/blog/src/lib/components/blog-list/blog-list-component.ts line ~69.

Fix

Subscribe with a no-op error callback — the service's errorSignal already drives the user-facing error state. Fix lands on the epic branch test/issue-307-e2e-full-coverage (spikersoft-angular PR #90).

Part of epic #307. Same defect class as #308 (/geography): API failure escaping as an unhandled rejection/exception and crashing a public page.

Found by the E2E anonymous walk (epic #307) after hardening the shell-mount assertion. ## Symptom When `GET /api/blog/posts` fails (API down, network error, CORS), `/blog` throws an uncaught client-side exception (`[pageerror] k` minified) instead of showing the error/retry UI. ## Root cause `BlogListComponent.loadBlogPosts()` calls `this.blogService.getAllBlogPosts().subscribe()` with **no error handler**. The service's `tap({ error })` records the failure in its `errorSignal` (which drives the retry UI) but does not swallow it — so RxJS rethrows the error from the bare `.subscribe()` as an unhandled exception. `libraries/features/blog/src/lib/components/blog-list/blog-list-component.ts` line ~69. ## Fix Subscribe with a no-op error callback — the service's `errorSignal` already drives the user-facing error state. Fix lands on the epic branch `test/issue-307-e2e-full-coverage` (spikersoft-angular PR #90). Part of epic #307. Same defect class as #308 (/geography): API failure escaping as an unhandled rejection/exception and crashing a public page.
spikerj added the bug label 2026-07-01 20:45:50 +00:00
spikerj commented 2026-07-01 20:50:44 +00:00
Author
Owner
Copy Link
Copy Source

Fix pushed to spikersoft-angular PR #90 (commit ee58881 on test/issue-307-e2e-full-coverage): BlogListComponent.loadBlogPosts() now subscribes with a no-op error callback; the service's errorSignal already drives the user-facing error/retry UI, so the rethrow from the bare .subscribe() was pure crash with no UX value.

Anonymous walk passes /blog (25/25 overall). Will close when PR #90 merges.

Fix pushed to spikersoft-angular PR #90 (commit `ee58881` on `test/issue-307-e2e-full-coverage`): `BlogListComponent.loadBlogPosts()` now subscribes with a no-op error callback; the service's `errorSignal` already drives the user-facing error/retry UI, so the rethrow from the bare `.subscribe()` was pure crash with no UX value. Anonymous walk passes `/blog` (25/25 overall). Will close when PR #90 merges.
spikerj commented 2026-07-01 22:45:00 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-angular PR #90 (merged to master). BlogListComponent.loadBlogPosts() subscribes with a no-op error callback; the service's errorSignal drives the retry UI. Anonymous walk passes /blog. Closing.

Resolved in spikersoft-angular PR #90 (merged to `master`). `BlogListComponent.loadBlogPosts()` subscribes with a no-op error callback; the service's errorSignal drives the retry UI. Anonymous walk passes `/blog`. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#310