System Activity overlay opens on global 'S' keypress, interfering with typing #468

New Issue

2026-07-11T03:40:09Z

spikerj commented

2026-07-11 03:40:09 +00:00

Summary

The global System Activity overlay (gear FAB + S shortcut, from the Art Studio activity launcher) opens whenever the S key is pressed at (near) the document level. This global keyboard shortcut interferes with legitimate typing in surfaces the shortcut guard doesn't recognize as editable — for example typing into a C# playground lesson editor — where pressing S unexpectedly pops the overlay instead of inserting the character.

Steps to reproduce

Sign in as a staff/admin user (the launcher is staff-gated).
Navigate to a page with a code editor / playground (e.g. a C# playground lesson).
Focus the editor and type a word containing s.
The System Activity overlay (Live pipeline state — queue, health, running tasks and events) toggles open instead of the keystroke being typed.

Expected behavior

The System Activity overlay should only open when the user clicks the gear icon in the bottom-right of the screen. It should not be bound to a global keyboard shortcut.

Root cause

ArtActivityLauncherComponent registers a @HostListener("document:keydown") that toggles the overlay on S. Its isEditableTarget guard only covers input/textarea/select/contentEditable, so editors and other focus-capturing widgets that don't match those checks still swallow the keystroke and trigger the overlay.

File: libraries/features/art-studio/src/lib/art-activity-launcher/art-activity-launcher.component.ts

Proposed fix

Remove the global S keyboard shortcut entirely. The overlay remains reachable via the always-available gear FAB in the bottom-right corner (staff-gated as today). Also update the launcher tooltip copy (currently System Activity (press S)) and specs accordingly.

Repo: spikersoft-angular

## Summary The global **System Activity** overlay (gear FAB + `S` shortcut, from the Art Studio activity launcher) opens whenever the `S` key is pressed at (near) the document level. This global keyboard shortcut interferes with legitimate typing in surfaces the shortcut guard doesn't recognize as editable — for example typing into a **C# playground lesson** editor — where pressing `S` unexpectedly pops the overlay instead of inserting the character. ## Steps to reproduce 1. Sign in as a staff/admin user (the launcher is staff-gated). 2. Navigate to a page with a code editor / playground (e.g. a C# playground lesson). 3. Focus the editor and type a word containing `s`. 4. The **System Activity** overlay (`Live pipeline state — queue, health, running tasks and events`) toggles open instead of the keystroke being typed. ## Expected behavior The System Activity overlay should **only** open when the user clicks the gear icon in the bottom-right of the screen. It should not be bound to a global keyboard shortcut. ## Root cause `ArtActivityLauncherComponent` registers a `@HostListener("document:keydown")` that toggles the overlay on `S`. Its `isEditableTarget` guard only covers `input`/`textarea`/`select`/`contentEditable`, so editors and other focus-capturing widgets that don't match those checks still swallow the keystroke and trigger the overlay. File: `libraries/features/art-studio/src/lib/art-activity-launcher/art-activity-launcher.component.ts` ## Proposed fix Remove the global `S` keyboard shortcut entirely. The overlay remains reachable via the always-available gear FAB in the bottom-right corner (staff-gated as today). Also update the launcher tooltip copy (currently `System Activity (press S)`) and specs accordingly. Repo: `spikersoft-angular`

spikerj commented

2026-07-11 23:26:28 +00:00