[High] canRun enables Run button while local runtime is still loading (when SignalR is connected) #56

New Issue

2026-05-05T04:14:58Z

spikerj commented

2026-05-05 04:14:58 +00:00

Severity: High (UX/correctness)

File: spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts (~264-275)

Problem: Current logic:

const connected = this.isConnected();
const localReady = this.activePath() === 'local' && this.runtimeStatus() === 'ready';
if (!connected && !localReady) return false;

If SignalR is connected AND user picked local execution, the guard is false && ... which short-circuits. The button stays enabled while WASM/Pyodide/QuickJS is still loading. Clicking Run before runtime ready can fail or hang.

Fix: Branch on activePath explicitly:

if (this.activePath() === 'local') return this.runtimeStatus() === 'ready';
return this.isConnected();

Acceptance criteria:

Run button disabled while local runtime is loading regardless of SignalR status
Run button disabled when SignalR disconnected and path is server
No regression to working local-only or server-only flows

**Severity:** High (UX/correctness) **File:** `spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts` (~264-275) **Problem:** Current logic: ```typescript const connected = this.isConnected(); const localReady = this.activePath() === 'local' && this.runtimeStatus() === 'ready'; if (!connected && !localReady) return false; ``` If SignalR is connected AND user picked local execution, the guard is `false && ...` which short-circuits. The button stays enabled while WASM/Pyodide/QuickJS is still loading. Clicking Run before runtime ready can fail or hang. **Fix:** Branch on activePath explicitly: ```typescript if (this.activePath() === 'local') return this.runtimeStatus() === 'ready'; return this.isConnected(); ``` **Acceptance criteria:** - [ ] Run button disabled while local runtime is loading regardless of SignalR status - [ ] Run button disabled when SignalR disconnected and path is server - [ ] No regression to working local-only or server-only flows

spikerj commented

2026-05-05 04:46:23 +00:00

Resolved.

canRun now branches on activePath first:

local -> returns false unless runtimeStatus() === 'ready'
otherwise -> returns false unless isConnected()

This fixes the short-circuit case where SignalR being connected hid a not-yet-ready local runtime.

File: spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts.

**Resolved.** `canRun` now branches on `activePath` first: - `local` -> returns false unless `runtimeStatus() === 'ready'` - otherwise -> returns false unless `isConnected()` This fixes the short-circuit case where SignalR being connected hid a not-yet-ready local runtime. File: `spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts`.

spikerj closed this issue

2026-05-05 04:51:57 +00:00

spikerj referenced this issue

2026-06-15 15:50:51 +00:00

JS playground: .prettierrc canonicalizes user content immediately on successful parse (mid-edit surprise) #81

spikerj referenced this issue

2026-06-15 15:51:02 +00:00

LanguageRunner: .prettierrc binding effects re-run on every Prettier option toggle even in beginner/lesson mode #80

spikerj referenced this issue

2026-07-02 15:06:50 +00:00

[Ratio unlocks 1/2] Backend: anonymous sessions, graded anon progress, horizon, sign-in claim #331

spikerj referenced this issue