spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Backend][Cleanup] Retire the pre-marker legacy manager classes (HexatileGameManager, ToolsManager, DBManager, CacheManager/ICacheManager) — DI-registered but architecturally superseded #576

New Issue
Open
opened 2026-07-14 17:13:13 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-14 17:13:13 +00:00
Owner
Copy Link
Copy Source

QA Team — filed 2026-07-14 from the README audit, at spikerj's direction. Three genuinely-dead files were already deleted in the audit branch (zero references, verified by grep across all non-obj sources):

  • SpikerSoft.Business/UserManager.cs — entirely empty class, 0 refs
  • SpikerSoft.Common/Interfaces/IAsposePdf.cs — 0 refs (vestigial; Aspose now lives only in worker projects)
  • SpikerSoft.Common/Utilities/HolidayManager.cs — only "consumer" was a commented-out line in SpikerSoft.Data/RedisOM/CalendarDay.cs (also removed). Worth noting it only ever knew 2025 US federal holidays (GetHolidays2025), so had anything actually used it, it would have been silently wrong all of 2026 — a good argument for not leaving date-hardcoded helpers lying around.

What remains (this ticket): the pre-marker "manager" classes that still have live references and therefore need a deliberate migration rather than a delete:

Class Refs Note
HexatileGameManager registered in ServiceCollectionExtensions superseded by the MediatR/marker-based domain structure
ToolsManager registered in ServiceCollectionExtensions; uses DBManager ditto
DBManager used by ToolsManager, TrailManager pre-SpikerDbContext data access
ICacheManager / CacheManager mutually referencing superseded by IRedisL2CacheService

Ask: migrate the remaining consumers onto the current patterns (SpikerDbContext / MediatR handlers / IRedisL2CacheService), then delete the manager classes and their DI registrations. Coordinate with #566 (Business decomposition) — these are the same tree.

**QA Team** — filed 2026-07-14 from the README audit, at spikerj's direction. **Three genuinely-dead files were already deleted** in the audit branch (zero references, verified by grep across all non-obj sources): - `SpikerSoft.Business/UserManager.cs` — **entirely empty class**, 0 refs - `SpikerSoft.Common/Interfaces/IAsposePdf.cs` — 0 refs (vestigial; Aspose now lives only in worker projects) - `SpikerSoft.Common/Utilities/HolidayManager.cs` — only "consumer" was a **commented-out line** in `SpikerSoft.Data/RedisOM/CalendarDay.cs` (also removed). Worth noting it only ever knew **2025** US federal holidays (`GetHolidays2025`), so had anything actually used it, it would have been silently wrong all of 2026 — a good argument for not leaving date-hardcoded helpers lying around. **What remains (this ticket):** the pre-marker "manager" classes that still have live references and therefore need a deliberate migration rather than a delete: | Class | Refs | Note | |---|---|---| | `HexatileGameManager` | registered in `ServiceCollectionExtensions` | superseded by the MediatR/marker-based domain structure | | `ToolsManager` | registered in `ServiceCollectionExtensions`; uses `DBManager` | ditto | | `DBManager` | used by `ToolsManager`, `TrailManager` | pre-`SpikerDbContext` data access | | `ICacheManager` / `CacheManager` | mutually referencing | superseded by `IRedisL2CacheService` | **Ask:** migrate the remaining consumers onto the current patterns (`SpikerDbContext` / MediatR handlers / `IRedisL2CacheService`), then delete the manager classes and their DI registrations. Coordinate with #566 (Business decomposition) — these are the same tree.
spikerj commented 2026-07-22 02:59:39 +00:00
Author
Owner
Copy Link
Copy Source

Board-sweep status (2026-07-22): the three verified-dead files ARE deleted on master (UserManager.cs, IAsposePdf.cs, HolidayManager.cs — confirmed absent). REMAINING: the live legacy managers the ticket targets beyond those — HexatileGameManager/IHexatileGameManager, ToolsManager/IToolsManager, base/DBManager.cs still exist in SpikerSoft.Business (HexatileGameManager still DI-registered in the API). Retiring those needs actual refactoring, not deletion — leaving open with scope now precise.

Board-sweep status (2026-07-22): the three verified-dead files ARE deleted on master (UserManager.cs, IAsposePdf.cs, HolidayManager.cs — confirmed absent). REMAINING: the live legacy managers the ticket targets beyond those — HexatileGameManager/IHexatileGameManager, ToolsManager/IToolsManager, base/DBManager.cs still exist in SpikerSoft.Business (HexatileGameManager still DI-registered in the API). Retiring those needs actual refactoring, not deletion — leaving open with scope now precise.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#576