spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[High] requestNewAttempt failures are silently swallowed in language-runner #61

New Issue
Closed
opened 2026-05-05 04:15:33 +00:00 by spikerj · 1 comment
spikerj commented 2026-05-05 04:15:33 +00:00
Owner
Copy Link
Copy Source

Severity: High (UX)

File: spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts (~1135-1138)

Problem: When requestNewAttempt() fails, only console.error runs. UI may leave a stale attempt token or show a misleading empty state. Users have no visible signal of the problem and no retry affordance.

Fix: Set submissionStatusSignal (or equivalent UI state) to a recoverable error state from the catch block; surface a retry button or toast.

Acceptance criteria:

  • Network failure during requestNewAttempt shows error to user
  • User can retry without page refresh
  • No silent state corruption
**Severity:** High (UX) **File:** `spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts` (~1135-1138) **Problem:** When `requestNewAttempt()` fails, only `console.error` runs. UI may leave a stale attempt token or show a misleading empty state. Users have no visible signal of the problem and no retry affordance. **Fix:** Set `submissionStatusSignal` (or equivalent UI state) to a recoverable error state from the catch block; surface a retry button or toast. **Acceptance criteria:** - [ ] Network failure during requestNewAttempt shows error to user - [ ] User can retry without page refresh - [ ] No silent state corruption
spikerj commented 2026-05-05 04:46:19 +00:00
Author
Owner
Copy Link
Copy Source

Resolved.

Added attemptErrorSignal to LanguageRunner. requestNewAttempt clears it on entry and sets it to a human-readable message in the catch block. Added retryAttempt() method bound to a new error banner in the template that renders an inline alert with a Retry button when the signal is set. Styled in csharp-runner.scss with .attempt-error (themed via existing CSS variables).

Files changed:

  • spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts
  • spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.html
  • spikersoft-angular/libraries/tools/src/components/csharp-runner/csharp-runner.scss
**Resolved.** Added `attemptErrorSignal` to `LanguageRunner`. `requestNewAttempt` clears it on entry and sets it to a human-readable message in the catch block. Added `retryAttempt()` method bound to a new error banner in the template that renders an inline alert with a Retry button when the signal is set. Styled in `csharp-runner.scss` with `.attempt-error` (themed via existing CSS variables). Files changed: - `spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.ts` - `spikersoft-angular/libraries/tools/src/components/language-runner/language-runner.html` - `spikersoft-angular/libraries/tools/src/components/csharp-runner/csharp-runner.scss`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#61