[Medium] AggregateKnowledgeCommandHandler has N+1 queries per domain group #62

New Issue

2026-05-05T04:15:43Z

spikerj commented

2026-05-05 04:15:43 +00:00

Severity: Medium (perf)

File: SpikerSoft.Business/Domain/Activity/Commands/AggregateKnowledge/AggregateKnowledgeCommandHandler.cs (~20-34)

Problem: Per-domain group, a separate UserKnowledgeProgress.Where(...).ToListAsync() query runs. With N domains this is N queries per aggregate operation.

Fix: Single bulk Where(p => p.UserId == userId).ToListAsync() then .GroupBy in memory.

Acceptance criteria:

One query per aggregation, regardless of domain count
Result identical to current behavior
Existing AggregateKnowledgeCommandHandlerTests still pass

**Severity:** Medium (perf) **File:** `SpikerSoft.Business/Domain/Activity/Commands/AggregateKnowledge/AggregateKnowledgeCommandHandler.cs` (~20-34) **Problem:** Per-domain group, a separate `UserKnowledgeProgress.Where(...).ToListAsync()` query runs. With N domains this is N queries per aggregate operation. **Fix:** Single bulk `Where(p => p.UserId == userId).ToListAsync()` then `.GroupBy` in memory. **Acceptance criteria:** - [ ] One query per aggregation, regardless of domain count - [ ] Result identical to current behavior - [ ] Existing AggregateKnowledgeCommandHandlerTests still pass

spikerj commented

2026-05-05 04:46:38 +00:00

Resolved.

Replaced the per-domain UserKnowledgeProgress.Where(...).ToListAsync() (N queries) with a single up-front load:

var existingProgressByDomain = (await context.UserKnowledgeProgress
        .Where(p => p.UserId == request.UserId)
        .ToListAsync(cancellationToken))
    .GroupBy(p => p.Domain)
    .ToDictionary(g => g.Key, g => g.First(), StringComparer.Ordinal);

The per-domain loop now does an in-memory TryGetValue against this dictionary. One query regardless of domain count.

File: SpikerSoft.Business/Domain/Activity/Commands/AggregateKnowledge/AggregateKnowledgeCommandHandler.cs.

**Resolved.** Replaced the per-domain `UserKnowledgeProgress.Where(...).ToListAsync()` (N queries) with a single up-front load: ```csharp var existingProgressByDomain = (await context.UserKnowledgeProgress .Where(p => p.UserId == request.UserId) .ToListAsync(cancellationToken)) .GroupBy(p => p.Domain) .ToDictionary(g => g.Key, g => g.First(), StringComparer.Ordinal); ``` The per-domain loop now does an in-memory `TryGetValue` against this dictionary. One query regardless of domain count. File: `SpikerSoft.Business/Domain/Activity/Commands/AggregateKnowledge/AggregateKnowledgeCommandHandler.cs`.

spikerj closed this issue

2026-05-05 04:51:57 +00:00

spikerj referenced this issue

2026-06-16 13:59:42 +00:00

[Bug] Minecraft (wasm-voxel) leaks global mouse/keyboard listeners that break input app-wide after leaving the game #228

spikerj referenced this issue

2026-06-16 13:59:45 +00:00

Bug: Calendar section - Event creation form fields unresponsive #181

spikerj referenced this issue

2026-06-16 13:59:50 +00:00

## [Bug] Text Input Box Unresponsive and Text Not Displayed Correctly in Fundraising Creation Modal #193

spikerj referenced this issue