[Medium] domain-detail route has no auth guard but API requires Authorize #64

New Issue

2026-05-05T04:15:55Z

spikerj commented

2026-05-05 04:15:55 +00:00

Severity: Medium (UX)

Files:

spikersoft-angular/projects/spikersoft/src/routes.ts (domain-detail route)
spikersoft-angular/projects/spikersoft/src/app/_components/learning/domain-detail/domain-detail.component.ts (~86-91)

Problem: Route has canActivate: [] (anonymous accessible) but the API endpoint requires [Authorize]. Anonymous users get a vague failed-load. The component's catch { } block also hides 401 vs 404 vs network errors.

Fix:

Add an AuthGuard (or matching pattern used elsewhere) on the route
Differentiate error types in the component's catch block: show login prompt for 401, not-found for 404, generic network error otherwise

Acceptance criteria:

Anonymous users see login prompt, not silent failure
Authenticated users get full functionality
Error states are distinguishable in UI

**Severity:** Medium (UX) **Files:** - `spikersoft-angular/projects/spikersoft/src/routes.ts` (domain-detail route) - `spikersoft-angular/projects/spikersoft/src/app/_components/learning/domain-detail/domain-detail.component.ts` (~86-91) **Problem:** Route has `canActivate: []` (anonymous accessible) but the API endpoint requires `[Authorize]`. Anonymous users get a vague failed-load. The component's `catch { }` block also hides 401 vs 404 vs network errors. **Fix:** - Add an `AuthGuard` (or matching pattern used elsewhere) on the route - Differentiate error types in the component's catch block: show login prompt for 401, not-found for 404, generic network error otherwise **Acceptance criteria:** - [ ] Anonymous users see login prompt, not silent failure - [ ] Authenticated users get full functionality - [ ] Error states are distinguishable in UI

spikerj commented

2026-05-05 04:46:48 +00:00

Resolved.

Applied two changes:

routes.ts -- the tree-of-knowledge/domain/:domainKey route now uses canActivate: [AuthGuard] to match the [Authorize] API endpoint.
domain-detail.component.ts -- replaced the silent catch {} with describeLoadError(err: unknown) which differentiates HttpErrorResponse statuses 0 (network), 401 (sign in), 403 (unauthorized), 404 (not found), and other (Failed to load domain detail (NNN)).

Files changed:

spikersoft-angular/projects/spikersoft/src/routes.ts
spikersoft-angular/projects/spikersoft/src/app/_components/learning/domain-detail/domain-detail.component.ts

**Resolved.** Applied two changes: 1. `routes.ts` -- the `tree-of-knowledge/domain/:domainKey` route now uses `canActivate: [AuthGuard]` to match the `[Authorize]` API endpoint. 2. `domain-detail.component.ts` -- replaced the silent `catch {}` with `describeLoadError(err: unknown)` which differentiates `HttpErrorResponse` statuses 0 (network), 401 (sign in), 403 (unauthorized), 404 (not found), and other (`Failed to load domain detail (NNN)`). Files changed: - `spikersoft-angular/projects/spikersoft/src/routes.ts` - `spikersoft-angular/projects/spikersoft/src/app/_components/learning/domain-detail/domain-detail.component.ts`

spikerj closed this issue

2026-05-05 04:51:57 +00:00

spikerj referenced this issue

2026-07-04 12:52:57 +00:00

[ArtStudio M4] Entire stack on the MacBook — native ArtPipeProcessor (no GPU in Docker on macOS), compose.mac, dev-mode GpuCoordinator #359

spikerj referenced this issue

2026-07-22 02:55:14 +00:00

[Enhancement] Legacy Systems (v86): self-host OS/disk catalogue parity with copy.sh/v86 — remove third‑party CDN dependency #47

Sign in to join this conversation.