[Backend] Final dead-code slice + AVIF failure diagnostics + Reader S927 renames (SonarQube S1144/S1481/S927 residue) #648

New Issue

2026-07-17T08:04:32Z

spikerj commented

2026-07-17 08:04:32 +00:00

The closing slice of the smell-family triage, every item verified in source:

Removed (dead by call-site proof): DockingController's 8 orphaned tuning constants (superseded by the adaptive per-spacecraft distance computation; MAX_DOCKING_DURATION's watchdog intent is covered by the wired STUCK_TIMEOUT detection), PathManager's cached-count/pool leftovers + GetSpacecraftRadius, MessagePackSerializer's 3 AoT-refactor helper corpses, AdaptivePathfinder/HierarchicalAStar dead constants, embeddings _mongoDatabase, QuizProgressEvent, BookActivitySource, ValidIso3Samples, and the whole IBookRepository/BookRepository scaffolding (hardcoded Gatsby test queries, AddBook ignoring its argument, zero callers — dangerously misleading DI registration).

Improved: AvifConverter logs stderr/stdout on non-zero exit (failed conversions were undiagnosable; the output reads also drain the pipes, so Sonar's remove-the-variable fix risked process deadlock — now they're used instead). Passport-info query result converted to a documented discard (the call carries the ViewPassport audit side effect — see the FP note in SonarQube).

Renamed: 4 new-code S927s in the Reader domain (ct → cancellationToken, interface conformance).

FP'd with proof during this pass: the [InlineArray] _element0 storage field (CS9169 on removal — language-mandated), the JSON-payload setters, the keep-alive roots.

Verified: slnf clean; GameServer 915, MetadataExtractor 4, Business Reader/Fundraiser 116, API 1296, Data 179 all pass.

The closing slice of the smell-family triage, every item verified in source: **Removed (dead by call-site proof):** DockingController's 8 orphaned tuning constants (superseded by the adaptive per-spacecraft distance computation; MAX_DOCKING_DURATION's watchdog intent is covered by the wired STUCK_TIMEOUT detection), PathManager's cached-count/pool leftovers + GetSpacecraftRadius, MessagePackSerializer's 3 AoT-refactor helper corpses, AdaptivePathfinder/HierarchicalAStar dead constants, embeddings _mongoDatabase, QuizProgressEvent, BookActivitySource, ValidIso3Samples, and the whole IBookRepository/BookRepository scaffolding (hardcoded Gatsby test queries, AddBook ignoring its argument, zero callers — dangerously misleading DI registration). **Improved:** AvifConverter logs stderr/stdout on non-zero exit (failed conversions were undiagnosable; the output reads also drain the pipes, so Sonar's remove-the-variable fix risked process deadlock — now they're used instead). Passport-info query result converted to a documented discard (the call carries the ViewPassport audit side effect — see the FP note in SonarQube). **Renamed:** 4 new-code S927s in the Reader domain (ct → cancellationToken, interface conformance). **FP'd with proof during this pass:** the [InlineArray] _element0 storage field (CS9169 on removal — language-mandated), the JSON-payload setters, the keep-alive roots. Verified: slnf clean; GameServer 915, MetadataExtractor 4, Business Reader/Fundraiser 116, API 1296, Data 179 all pass.

spikerj commented

2026-07-17 08:46:16 +00:00

Resolved in spikersoft-backend PR #353 (merged, 30/30 checks green). Full details in the ticket body; the smell-family triage's self-serviceable backlog is now fully drained. Closing.

spikerj closed this issue

2026-07-17 08:46:16 +00:00

spikerj commented

2026-07-17 09:26:45 +00:00

Follow-up PR #354 also merged (4/4 green) — the two S1481 cascades from the parameter removals are resolved, with the UpdateDockingTimers side effect preserved and documented in-code. The backend triage loop's self-serviceable backlog is now fully drained.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#648