spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Reader][Social] Community badge opens the sidebar on Chapters, not the Community tab #649

New Issue
Closed
opened 2026-07-17 13:46:16 +00:00 by spikerj · 2 comments
spikerj commented 2026-07-17 13:46:16 +00:00
Owner
Copy Link
Copy Source

Follow-up to #634 (PR #221). The toolbar people-badge's onShowCommunity() only opens the sidebar (sidebarVisible.set(true)) — it lands on the Chapters tab, so the user has to hunt for Community. The approved WS-2 plan specifies the badge "opens sidebar Community tab."

Also folds in an out-of-order-response guard on the sidebar's getSocialBookmarks effect (rapid page turns could paint a stale page's shared bookmarks — the #275/LanguageRunner stale-response rule).

This fix was written during #634 but landed on the branch after PR #221 was already merged (the push recreated the deleted branch), so it never reached master. Recovering it here.

Fix: shell fires a one-shot communityRequest token (the searchScrollRequest idiom); the sidebar reacts by setting activeTab to the Community index, computed from file type (Community is always the last tab: 2 for PDF, 3 for EPUB). Both behaviors locked with sidebar specs.

PR: spikersoft-angular fix/reader-community-badge-tab.

Follow-up to #634 (PR #221). The toolbar people-badge's `onShowCommunity()` only opens the sidebar (`sidebarVisible.set(true)`) — it lands on the Chapters tab, so the user has to hunt for Community. The approved WS-2 plan specifies the badge "opens sidebar Community tab." Also folds in an out-of-order-response guard on the sidebar's `getSocialBookmarks` effect (rapid page turns could paint a stale page's shared bookmarks — the #275/LanguageRunner stale-response rule). This fix was written during #634 but landed on the branch **after** PR #221 was already merged (the push recreated the deleted branch), so it never reached master. Recovering it here. Fix: shell fires a one-shot `communityRequest` token (the `searchScrollRequest` idiom); the sidebar reacts by setting `activeTab` to the Community index, computed from file type (Community is always the last tab: 2 for PDF, 3 for EPUB). Both behaviors locked with sidebar specs. PR: spikersoft-angular `fix/reader-community-badge-tab`.
spikerj commented 2026-07-17 14:14:55 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #358 (merged to master). RedisClusterState's three derived node projections now materialize once into backing fields instead of re-filtering+re-allocating per access. Zero behavior change, SystemRemediation 82/82. The 3 S2365 CRITICALs auto-close on the next scan. Closing.

Resolved in spikersoft-backend PR #358 (merged to master). RedisClusterState's three derived node projections now materialize once into backing fields instead of re-filtering+re-allocating per access. Zero behavior change, SystemRemediation 82/82. The 3 S2365 CRITICALs auto-close on the next scan. Closing.
spikerj commented 2026-07-17 14:15:04 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-angular PR #222 (merged to master). The toolbar Community badge now fires a one-shot token so the sidebar jumps to the Community tab (index computed from file type), plus the stale-social-fetch guard. Closing.

Resolved in spikersoft-angular PR #222 (merged to `master`). The toolbar Community badge now fires a one-shot token so the sidebar jumps to the Community tab (index computed from file type), plus the stale-social-fetch guard. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#649