[Medium] Dead BSON conversion methods in GetTrailByIdQueryHandler #65

New Issue

2026-05-05T04:16:00Z

spikerj commented

2026-05-05 04:16:00 +00:00

Severity: Medium (maintainability)

File: SpikerSoft.Business/Domain/Map/Trails/Queries/GetTrailById/GetTrailByIdQueryHandler.cs (~63-116)

Problem: ConvertBsonToGeometry, ConvertBsonToDictionary, ConvertBsonValueToObject are declared but never called. ConvertToDto uses JsonSerializer exclusively. Dead code increases audit surface and confuses readers.

Fix: Remove the unused methods, OR if they're intentionally retained for an upcoming BSON path, leave a clear comment explaining why and add a // TODO issue link.

Acceptance criteria:

Dead methods removed (or documented with intent)
Build still passes
No behavior change

**Severity:** Medium (maintainability) **File:** `SpikerSoft.Business/Domain/Map/Trails/Queries/GetTrailById/GetTrailByIdQueryHandler.cs` (~63-116) **Problem:** `ConvertBsonToGeometry`, `ConvertBsonToDictionary`, `ConvertBsonValueToObject` are declared but never called. `ConvertToDto` uses `JsonSerializer` exclusively. Dead code increases audit surface and confuses readers. **Fix:** Remove the unused methods, OR if they're intentionally retained for an upcoming BSON path, leave a clear comment explaining why and add a `// TODO` issue link. **Acceptance criteria:** - [ ] Dead methods removed (or documented with intent) - [ ] Build still passes - [ ] No behavior change

spikerj commented

2026-05-05 04:47:08 +00:00

Resolved.

Removed the unused ConvertBsonToGeometry, ConvertBsonToDictionary, and ConvertBsonValueToObject methods plus the using MongoDB.Bson; import. Also simplified the handler -- the outer try/catch that re-wrapped every exception (including the not-found case) in a generic Exception was removed; the typed TrailNotFoundException (issue #57) now propagates cleanly.

File: SpikerSoft.Business/Domain/Map/Trails/Queries/GetTrailById/GetTrailByIdQueryHandler.cs.

**Resolved.** Removed the unused `ConvertBsonToGeometry`, `ConvertBsonToDictionary`, and `ConvertBsonValueToObject` methods plus the `using MongoDB.Bson;` import. Also simplified the handler -- the outer `try/catch` that re-wrapped every exception (including the not-found case) in a generic `Exception` was removed; the typed `TrailNotFoundException` (issue #57) now propagates cleanly. File: `SpikerSoft.Business/Domain/Map/Trails/Queries/GetTrailById/GetTrailByIdQueryHandler.cs`.

spikerj closed this issue

2026-05-05 04:51:57 +00:00

spikerj referenced this issue

2026-06-17 04:58:49 +00:00

chore(deps): frontend dev/build/test tooling — minor & patch roll-up #229

spikerj referenced this issue

2026-07-04 16:22:15 +00:00

[ArtStudio] Stage requests for unconsumed stages are silently dropped — asset hangs InProgress forever #360

spikerj referenced this issue

2026-07-04 16:22:17 +00:00

[ArtStudio] ArtifactKinds derives kind from stage only — OBJ stored as kind "mesh-glb" #361

Sign in to join this conversation.