[Medium] FreePlayCodeExecutorFactory silently picks last duplicate registration #66

New Issue

2026-05-05T04:16:06Z

spikerj commented

2026-05-05 04:16:06 +00:00

Severity: Medium (DI safety)

File: SpikerSoft.Business/Domain/CodeExecution/Execution/FreePlayCodeExecutorFactory.cs (~16-18)

Problem: GroupBy(...).ToDictionary(..., g => g.Last()) silently picks the last registrar for duplicate LanguageId values. Misconfiguration (duplicate registrations) goes unnoticed.

Fix: Throw a descriptive exception when a duplicate is detected:

var duplicates = executors.GroupBy(e => e.LanguageId).Where(g => g.Count() > 1).ToList();
if (duplicates.Any())
    throw new InvalidOperationException($"Duplicate FreePlay executor registrations: {string.Join(', ', duplicates.Select(d => d.Key))}");

Acceptance criteria:

Duplicate registration throws on factory construction
Existing single-registration behavior unchanged

**Severity:** Medium (DI safety) **File:** `SpikerSoft.Business/Domain/CodeExecution/Execution/FreePlayCodeExecutorFactory.cs` (~16-18) **Problem:** `GroupBy(...).ToDictionary(..., g => g.Last())` silently picks the last registrar for duplicate `LanguageId` values. Misconfiguration (duplicate registrations) goes unnoticed. **Fix:** Throw a descriptive exception when a duplicate is detected: ```csharp var duplicates = executors.GroupBy(e => e.LanguageId).Where(g => g.Count() > 1).ToList(); if (duplicates.Any()) throw new InvalidOperationException($"Duplicate FreePlay executor registrations: {string.Join(', ', duplicates.Select(d => d.Key))}"); ``` **Acceptance criteria:** - [ ] Duplicate registration throws on factory construction - [ ] Existing single-registration behavior unchanged

spikerj commented

2026-05-05 04:47:09 +00:00

Resolved.

The factory now scans for duplicate LanguageId registrations and throws InvalidOperationException with the offending key(s) and counts during construction:

var duplicates = grouped.Where(g => g.Count() > 1).Select(g => $"{g.Key} ({g.Count()})").ToList();
if (duplicates.Count > 0)
    throw new InvalidOperationException("Duplicate IFreePlayCodeExecutor registrations detected: ...");

Single-registration behaviour is unchanged. Misconfiguration now fails loudly at startup instead of silently selecting the last registrant.

File: SpikerSoft.Business/Domain/CodeExecution/Execution/FreePlayCodeExecutorFactory.cs.

**Resolved.** The factory now scans for duplicate `LanguageId` registrations and throws `InvalidOperationException` with the offending key(s) and counts during construction: ```csharp var duplicates = grouped.Where(g => g.Count() > 1).Select(g => $"{g.Key} ({g.Count()})").ToList(); if (duplicates.Count > 0) throw new InvalidOperationException("Duplicate IFreePlayCodeExecutor registrations detected: ..."); ``` Single-registration behaviour is unchanged. Misconfiguration now fails loudly at startup instead of silently selecting the last registrant. File: `SpikerSoft.Business/Domain/CodeExecution/Execution/FreePlayCodeExecutorFactory.cs`.

spikerj closed this issue

2026-05-05 04:51:57 +00:00

spikerj referenced this issue

2026-06-17 05:39:54 +00:00

chore(deps): frontend app-runtime libraries — minor & patch roll-up #230

spikerj referenced this issue

2026-07-04 17:17:05 +00:00

[ArtStudio P3] Concept + texturing stages — SDXL concept image with safety checker, PBR texturing, stage chaining #349

spikerj referenced this issue

2026-07-22 02:57:52 +00:00

[Bug][Infra][Jaeger] jaeger_elasticsearch crash-loops (0/1) — ES 7.17.0 image started against a data volume written by ES 8.11.0, restarting every ~30s #551

Sign in to join this conversation.