spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove abandoned commented-out code blocks (S125) #667

New Issue
Closed
opened 2026-07-17 16:51:37 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 16:51:37 +00:00
Owner
Copy Link
Copy Source

Removed abandoned commented-out prototype code flagged by SonarQube S125, after evaluating each block individually (not a blanket sweep):

Removed (no live references, no re-enable rationale):

  • Asset.cs — commented Type/SubType/Approvals properties + dead AssetType/SubType enum definitions (the live AssetType is the ArtStudio one).
  • ToolsController.cs — two commented var ip = ... alternatives and the fully commented-out GetIPV4Trace action (unreferenced).
  • HexatileGameManager.cs — commented DetermineRoomType(), a duplicate RoomType enum (live one lives in HexagonData.cs), GetSixRandomHeros(), a stray var noise = new PerlinNoise line, and the entire commented PerlinNoise class. Live LandType/GameStage enums retained.

Comment-only deletions → zero runtime impact. dotnet build SpikerSoft.UnitTests.slnf clean (0 errors).

Deliberately NOT removed (accepted in SonarQube as documented/intentional, not dead residue): CustomersController migration-complete record, SpaceZone/BaseZone disabled-test notes, NotificationsHub optional-authz placeholder.

Follow-up (needs approval): two files are entirely commented-out and unreferenced and should be deleted outright — SpikerSoft.Api/Domain/Mail/MailController.cs (48 lines, all comment) and SpikerSoft.Common/Models/Approval.cs. Automated file deletion was withheld pending a maintainer OK; their S125 findings remain open until then.

Removed abandoned commented-out prototype code flagged by SonarQube S125, after evaluating each block individually (not a blanket sweep): **Removed (no live references, no re-enable rationale):** - `Asset.cs` — commented Type/SubType/Approvals properties + dead `AssetType`/`SubType` enum definitions (the live `AssetType` is the ArtStudio one). - `ToolsController.cs` — two commented `var ip = ...` alternatives and the fully commented-out `GetIPV4Trace` action (unreferenced). - `HexatileGameManager.cs` — commented `DetermineRoomType()`, a duplicate `RoomType` enum (live one lives in `HexagonData.cs`), `GetSixRandomHeros()`, a stray `var noise = new PerlinNoise` line, and the entire commented `PerlinNoise` class. Live `LandType`/`GameStage` enums retained. Comment-only deletions → zero runtime impact. `dotnet build SpikerSoft.UnitTests.slnf` clean (0 errors). **Deliberately NOT removed** (accepted in SonarQube as documented/intentional, not dead residue): `CustomersController` migration-complete record, `SpaceZone`/`BaseZone` disabled-test notes, `NotificationsHub` optional-authz placeholder. **Follow-up (needs approval):** two files are entirely commented-out and unreferenced and should be deleted outright — `SpikerSoft.Api/Domain/Mail/MailController.cs` (48 lines, all comment) and `SpikerSoft.Common/Models/Approval.cs`. Automated file deletion was withheld pending a maintainer OK; their S125 findings remain open until then.
spikerj commented 2026-07-17 18:03:41 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #366 (merged to master). Removed abandoned commented-out prototype code (S125) from Asset.cs, ToolsController.cs, HexatileGameManager.cs; comment-only deletions, zero runtime impact. Two fully-dead files (MailController.cs, Approval.cs) noted as delete-outright follow-ups. All build/test contexts green; merged past the non-blocking notify job. Closing.

Resolved in spikersoft-backend PR #366 (merged to `master`). Removed abandoned commented-out prototype code (S125) from Asset.cs, ToolsController.cs, HexatileGameManager.cs; comment-only deletions, zero runtime impact. Two fully-dead files (MailController.cs, Approval.cs) noted as delete-outright follow-ups. All build/test contexts green; merged past the non-blocking notify job. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#667