spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(3dmodel): consolidate duplicated auth checks into TryGetUserId helper (S1192) #680

New Issue
Closed
opened 2026-07-17 19:58:27 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 19:58:27 +00:00
Owner
Copy Link
Copy Source

Continuation of #677 (ArtStudioController auth consolidation). ThreeDModelController repeats the identical token-user-id auth check in all 4 endpoints (var userId = User.FindFirst(ClaimTypes.NameIdentifier)?.Value; if empty return Unauthorized('User ID not found in token')) — SonarQube S1192 flagged the message duplicated 4x.

Fix: extract a private TryGetUserId(out userId, out ActionResult? error) helper (same pattern as #376) and replace all 4 blocks. Behavior identical; all 18 ThreeDModelController tests pass; build clean.

Note: the auth pattern is codebase-wide (~11 controllers). ArtStudioPresetsController (4x) uses a UserId() helper variant and Position/Profile/etc use assorted messages — a shared ControllerBase extension could unify them all, deferred to avoid churn/conflicts while the team is moving fast. SonarQube rule csharpsquid:S1192.

Continuation of #677 (ArtStudioController auth consolidation). ThreeDModelController repeats the identical token-user-id auth check in all 4 endpoints (var userId = User.FindFirst(ClaimTypes.NameIdentifier)?.Value; if empty return Unauthorized('User ID not found in token')) — SonarQube S1192 flagged the message duplicated 4x. Fix: extract a private TryGetUserId(out userId, out ActionResult? error) helper (same pattern as #376) and replace all 4 blocks. Behavior identical; all 18 ThreeDModelController tests pass; build clean. Note: the auth pattern is codebase-wide (~11 controllers). ArtStudioPresetsController (4x) uses a UserId() helper variant and Position/Profile/etc use assorted messages — a shared ControllerBase extension could unify them all, deferred to avoid churn/conflicts while the team is moving fast. SonarQube rule csharpsquid:S1192.
spikerj commented 2026-07-22 02:43:22 +00:00
Author
Owner
Copy Link
Copy Source

Verified complete: backend PR #378 merged; ThreeDModelController now uses TryGetUserId (5 call sites) with the duplicated checks consolidated. Closing.

Verified complete: backend PR #378 merged; ThreeDModelController now uses TryGetUserId (5 call sites) with the duplicated checks consolidated. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#680