spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

perf(keycloak): cache JsonSerializerOptions instead of per-call allocation (CA1869) #681

New Issue
Closed
opened 2026-07-17 20:04:18 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 20:04:18 +00:00
Owner
Copy Link
Copy Source

KeycloakAdminService allocated a fresh JsonSerializerOptions at 4 serialize/deserialize sites (1x DefaultIgnoreCondition=WhenWritingNull, 3x PropertyNameCaseInsensitive=true). System.Text.Json caches type metadata per options-instance, so a new instance each call rebuilds that reflection cache (CA1869) — avoidable allocation/CPU on the Keycloak admin path (user create/update/query).

Hoisted to two static readonly instances shared across the sites. Identical config → no behavior change; immutable after first use, safe for concurrent reads. All 41 KeycloakAdminService tests pass; build clean.

(Continuation of #364 which fixed the same pattern in BookController. 66 CA1869 remain, mostly in test files where per-call allocation is irrelevant + a few other production services.) SonarQube rule external_roslyn:CA1869.

KeycloakAdminService allocated a fresh JsonSerializerOptions at 4 serialize/deserialize sites (1x DefaultIgnoreCondition=WhenWritingNull, 3x PropertyNameCaseInsensitive=true). System.Text.Json caches type metadata per options-instance, so a new instance each call rebuilds that reflection cache (CA1869) — avoidable allocation/CPU on the Keycloak admin path (user create/update/query). Hoisted to two static readonly instances shared across the sites. Identical config → no behavior change; immutable after first use, safe for concurrent reads. All 41 KeycloakAdminService tests pass; build clean. (Continuation of #364 which fixed the same pattern in BookController. 66 CA1869 remain, mostly in test files where per-call allocation is irrelevant + a few other production services.) SonarQube rule external_roslyn:CA1869.
spikerj commented 2026-07-17 20:05:28 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #379 (merged to master). Hoisted KeycloakAdminService's 4 per-call JsonSerializerOptions to 2 static readonly instances; all 41 tests pass. Closing.

Resolved in spikersoft-backend PR #379 (merged to master). Hoisted KeycloakAdminService's 4 per-call JsonSerializerOptions to 2 static readonly instances; all 41 tests pass. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#681