spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

perf(mcp): cache CalendarTools JsonSerializerOptions instead of per-call allocation (CA1869) #682

New Issue
Closed
opened 2026-07-17 20:07:27 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 20:07:27 +00:00
Owner
Copy Link
Copy Source

CalendarTools (MCP server) serialized its tool responses with a fresh JsonSerializerOptions ({ WriteIndented = true, PropertyNamingPolicy = CamelCase }) at all 4 serialize sites. System.Text.Json caches type metadata per options-instance, so a new instance each call rebuilds that reflection cache (CA1869).

Hoist the identical config to one static readonly IndentedCamelCase instance. No behavior change; immutable after first use, safe for concurrent reads. Build clean. Continuation of #364 (BookController) / #379 (KeycloakAdminService). SonarQube rule external_roslyn:CA1869.

CalendarTools (MCP server) serialized its tool responses with a fresh JsonSerializerOptions ({ WriteIndented = true, PropertyNamingPolicy = CamelCase }) at all 4 serialize sites. System.Text.Json caches type metadata per options-instance, so a new instance each call rebuilds that reflection cache (CA1869). Hoist the identical config to one static readonly IndentedCamelCase instance. No behavior change; immutable after first use, safe for concurrent reads. Build clean. Continuation of #364 (BookController) / #379 (KeycloakAdminService). SonarQube rule external_roslyn:CA1869.
spikerj commented 2026-07-17 20:10:54 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #380 (merged to master). Hoisted CalendarTools' 4 per-call JsonSerializerOptions to one static readonly instance; no behavior change. Closing.

Resolved in spikersoft-backend PR #380 (merged to master). Hoisted CalendarTools' 4 per-call JsonSerializerOptions to one static readonly instance; no behavior change. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#682