spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

Api: remove stale IsAotCompatible flag (abandoned AOT experiment emitting 115 IL2026/IL3050 warnings) #683

New Issue
Closed
opened 2026-07-17 20:32:48 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 20:32:48 +00:00
Owner
Copy Link
Copy Source

Problem

SpikerSoft.Api/SpikerSoft.API.csproj sets <IsAotCompatible>true</IsAotCompatible>, a leftover from a .NET 10-preview AOT experiment (PublishAot, PublishTrimmed, TrimMode are all commented out right below it). That single flag turns on the trim/AOT analyzers, which emit 115 warnings in Api alone (66 IL2026 RequiresUnreferencedCode + 49 IL3050 RequiresDynamicCode).

These warnings are noise for this host: Api is published framework-dependent (Dockerfile: dotnet publish /p:UseAppHost=false, no PublishAot/PublishTrimmed) and runs as a normal JIT service on the Swarm. Its MVC + MediatR + EF Core Mongo + reflection-based System.Text.Json/Mongo serialization stack is fundamentally not trim/AOT-safe, so the analyzer is flagging real trim-unsafety against a publish mode Api never uses.

Fix

Remove <IsAotCompatible>true</IsAotCompatible> from the Api csproj (analyzer-only flag; produces identical IL and an identical published artifact). A comment documents why the host is intentionally not AOT/trim-targeted, so the flag is not reinnstated. This clears all 115 IL2026/IL3050 findings at the source rather than dispositioning them one by one, and stops future IL-warning accumulation.

GameServer (genuinely PublishAot=true) is untouched — its trim/AOT analyzers stay on and its warnings, if any, remain real.

Verification

  • dotnet build SpikerSoft.API.csproj -c Release: Build succeeded, 0 IL2026/IL3050 warnings (was 115).
  • dotnet build SpikerSoft.UnitTests.slnf -c Release: Build succeeded, 0 errors.
  • No runtime/behavior change: analyzer-only MSBuild property, framework-dependent publish unchanged.
## Problem `SpikerSoft.Api/SpikerSoft.API.csproj` sets `<IsAotCompatible>true</IsAotCompatible>`, a leftover from a .NET 10-preview AOT experiment (`PublishAot`, `PublishTrimmed`, `TrimMode` are all commented out right below it). That single flag turns on the trim/AOT analyzers, which emit **115 warnings** in Api alone (66 IL2026 `RequiresUnreferencedCode` + 49 IL3050 `RequiresDynamicCode`). These warnings are noise for this host: Api is published **framework-dependent** (`Dockerfile`: `dotnet publish /p:UseAppHost=false`, no `PublishAot`/`PublishTrimmed`) and runs as a normal JIT service on the Swarm. Its MVC + MediatR + EF Core Mongo + reflection-based `System.Text.Json`/Mongo serialization stack is fundamentally not trim/AOT-safe, so the analyzer is flagging real trim-unsafety against a publish mode Api never uses. ## Fix Remove `<IsAotCompatible>true</IsAotCompatible>` from the Api csproj (analyzer-only flag; produces identical IL and an identical published artifact). A comment documents why the host is intentionally not AOT/trim-targeted, so the flag is not reinnstated. This clears all 115 IL2026/IL3050 findings at the source rather than dispositioning them one by one, and stops future IL-warning accumulation. GameServer (genuinely `PublishAot=true`) is untouched — its trim/AOT analyzers stay on and its warnings, if any, remain real. ## Verification - `dotnet build SpikerSoft.API.csproj -c Release`: **Build succeeded, 0 IL2026/IL3050 warnings** (was 115). - `dotnet build SpikerSoft.UnitTests.slnf -c Release`: **Build succeeded, 0 errors**. - No runtime/behavior change: analyzer-only MSBuild property, framework-dependent publish unchanged.
spikerj commented 2026-07-17 20:58:03 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #381 (merged to master). Removed the stale <IsAotCompatible>true> from SpikerSoft.API.csproj (leftover from the abandoned .NET 10-preview AOT trial), which cleared all 115 IL2026/IL3050 warnings at the source with zero runtime change. CI: both amd64+arm64 image builds and unit tests passed green. Closing.

Resolved in spikersoft-backend PR #381 (merged to `master`). Removed the stale `<IsAotCompatible>true>` from `SpikerSoft.API.csproj` (leftover from the abandoned .NET 10-preview AOT trial), which cleared all 115 IL2026/IL3050 warnings at the source with zero runtime change. CI: both amd64+arm64 image builds and unit tests passed green. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#683