spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug][Blog][Angular] Media delete is broken end-to-end — placeholder handler AND a confirm button with no click binding (epic #705) #706

New Issue
Closed
opened 2026-07-19 01:15:00 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-19 01:15:00 +00:00
Owner
Copy Link
Copy Source

Epic #705. Two independent breaks stack so per-media deletion silently does nothing:

  1. blog-entry-component.ts removeMedia() only shows a placeholder snackbar (app.runtime.snackbars.mediaRemovedPlaceholder) — no backend call exists for media removal at all.
  2. The blog-local ConfirmDeleteComponent's Remove button has no (click) handler (confirm-delete.component.html) — it never closes the dialog with true, so even the placeholder path can't fire from the dialog.

Fix shape: backend endpoint (DELETE /posts/{id}/media/{mediaId}, owner-or-staff like post delete) that removes the embedded media entry + purges the artifact via the #422 BlogArtifactPurger (single-file, blogs bucket + disk, workflow doc cleanup); Angular wires removeMedia to it. Prefer replacing the broken local dialog with the shared @spikersoft/ui-confirm-dialog (the owner-delete flow in angular #420 shows the pattern — the media preview in the local dialog is the only thing worth keeping).

Priority: high — it's a visible affordance that lies to the user.

Epic #705. Two independent breaks stack so per-media deletion silently does nothing: 1. `blog-entry-component.ts` `removeMedia()` only shows a placeholder snackbar (`app.runtime.snackbars.mediaRemovedPlaceholder`) — no backend call exists for media removal at all. 2. The blog-local `ConfirmDeleteComponent`'s **Remove button has no `(click)` handler** (`confirm-delete.component.html`) — it never closes the dialog with `true`, so even the placeholder path can't fire from the dialog. **Fix shape:** backend endpoint (DELETE `/posts/{id}/media/{mediaId}`, owner-or-staff like post delete) that removes the embedded media entry + purges the artifact via the #422 `BlogArtifactPurger` (single-file, `blogs` bucket + disk, workflow doc cleanup); Angular wires `removeMedia` to it. Prefer replacing the broken local dialog with the shared `@spikersoft/ui-confirm-dialog` (the owner-delete flow in angular #420 shows the pattern — the media preview in the local dialog is the only thing worth keeping). Priority: high — it's a visible affordance that lies to the user.
spikerj commented 2026-07-22 02:51:29 +00:00
Author
Owner
Copy Link
Copy Source

Verified fixed end-to-end on master (landed via #747):

  1. Backend endpoint exists — DELETE /api/blog/posts/{postId}/media/{mediaId} → RemoveMediaFromPostCommand (BlogController line 771), owner-or-staff soft delete (the artifact purge path via the #422 purger).
  2. Angular wired — blog-entry-component.removeMedia() now calls blogService.removeMediaFromPost(postId, mediaId) and reloads the shared list; the placeholder snackbar is gone (success shows mediaRemoved, not mediaRemovedPlaceholder).
  3. Confirm dialog fixed — confirm-delete.component.html's Remove button now has [mat-dialog-close]="true" (in-code comment: "this button previously closed with no result, so confirms were dropped"), so afterClosed() receives true and the removal actually runs.

The affordance no longer lies. Closing.

Verified fixed end-to-end on `master` (landed via #747): 1. **Backend endpoint exists** — `DELETE /api/blog/posts/{postId}/media/{mediaId}` → `RemoveMediaFromPostCommand` (`BlogController` line 771), owner-or-staff soft delete (the artifact purge path via the #422 purger). 2. **Angular wired** — `blog-entry-component.removeMedia()` now calls `blogService.removeMediaFromPost(postId, mediaId)` and reloads the shared list; the placeholder snackbar is gone (success shows `mediaRemoved`, not `mediaRemovedPlaceholder`). 3. **Confirm dialog fixed** — `confirm-delete.component.html`'s Remove button now has `[mat-dialog-close]="true"` (in-code comment: "this button previously closed with no result, so confirms were dropped"), so `afterClosed()` receives `true` and the removal actually runs. The affordance no longer lies. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#706