spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: duplicate min-height in x86-playground SCSS (css:S4656) #731

New Issue
Closed
opened 2026-07-20 03:59:45 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-20 03:59:45 +00:00
Owner
Copy Link
Copy Source

Bug (SonarQube css:S4656)

libraries/features/dev-tools-x86-playground/src/lib/assembly-playground.component.scss — the .lesson-mobile-pane rule declared min-height twice: min-height: 200px then min-height: 0. Per CSS cascade the last wins, so min-height: 200px was dead (never applied); and because the pane is flex: 0 0 auto (flex-shrink 0), min-height: 0 is itself inert. Net: a confusing duplicate where the 200px value silently did nothing.

Fix

Remove the overridden min-height: 200px declaration, keeping the effective min-height: 0. Behavior-neutral — the rendered layout is unchanged (min-height:0 was already the winning value). Resolves the duplicate-property finding.

Note for the author: if a 200px floor was actually intended for the mobile pane, the correct change is instead to drop min-height: 0 (and reconsider it against flex: 0 0 auto). Flagging in case the floor was the intent — but that would change rendered behavior, so it's left as a design decision.

SonarQube

learn.spikersoft.com — https://sonarqube.spikersoft.com/dashboard?id=learn.spikersoft.com (rule css:S4656, assembly-playground.component.scss:91)

Filed from the SonarQube reliability-backlog triage loop.

### Bug (SonarQube `css:S4656`) `libraries/features/dev-tools-x86-playground/src/lib/assembly-playground.component.scss` — the `.lesson-mobile-pane` rule declared `min-height` **twice**: `min-height: 200px` then `min-height: 0`. Per CSS cascade the last wins, so `min-height: 200px` was **dead** (never applied); and because the pane is `flex: 0 0 auto` (flex-shrink 0), `min-height: 0` is itself inert. Net: a confusing duplicate where the `200px` value silently did nothing. ### Fix Remove the overridden `min-height: 200px` declaration, keeping the effective `min-height: 0`. **Behavior-neutral** — the rendered layout is unchanged (min-height:0 was already the winning value). Resolves the duplicate-property finding. _Note for the author:_ if a **200px floor was actually intended** for the mobile pane, the correct change is instead to drop `min-height: 0` (and reconsider it against `flex: 0 0 auto`). Flagging in case the floor was the intent — but that would change rendered behavior, so it's left as a design decision. ### SonarQube `learn.spikersoft.com` — https://sonarqube.spikersoft.com/dashboard?id=learn.spikersoft.com (rule `css:S4656`, `assembly-playground.component.scss:91`) _Filed from the SonarQube reliability-backlog triage loop._
spikerj commented 2026-07-21 19:38:41 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-angular PR #456 (merged): dead duplicate min-height removed from .lesson-mobile-pane. Closing.

Resolved in spikersoft-angular PR #456 (merged): dead duplicate min-height removed from .lesson-mobile-pane. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#731