spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug] DM roster: admin-parents don't see their children (exclusive role branches) + avatars generic for ProfileImageId users (#767 follow-up) #770

New Issue
Closed
opened 2026-07-21 15:55:44 +00:00 by spikerj · 2 comments
spikerj commented 2026-07-21 15:55:44 +00:00
Owner
Copy Link
Copy Source

Live-test follow-ups on #767 messaging (2026-07-21):

1. Parent can't see their child in the "new message" roster (child sees parent fine).
Diagnosed: MessagingAccessService.GetRosterAsync branches are EXCLUSIVE — admin/staff callers get only the currently-online list and never reach the parent branch. spikerj is both admin and parent (of toddcan, prod's only minor), so when the child's presence key had lapsed the roster was empty and the child never appeared. Spec says parents ALWAYS see their kids. Fix: make the roster additive — staff/admin online-users ∪ own children (always listed) ∪ (child→parent), deduped with family relationships winning the label. Presence itself verified healthy (both users' messaging-presence:* keys live in Redis).

2. Chat shows generic icons instead of profile pictures.
Both test users have AvatarGridFsId: null but ProfileImageId set — the normal profile-picture flow populates ProfileImageId/Images, while GET api/profile/{userId}/avatar and the messaging DTOs only consult AvatarGridFsId. Fix: GetAvatarQueryHandler falls back AvatarGridFsId ?? ProfileImageId (same GridFS service; images/{imageId} is already AllowAnonymous, so no new exposure), and messaging DTOs use the same coalesce for their has-avatar indicator.

Both fixes backend-only; frontend already renders the image whenever the indicator is non-null.

Live-test follow-ups on #767 messaging (2026-07-21): **1. Parent can't see their child in the "new message" roster (child sees parent fine).** Diagnosed: `MessagingAccessService.GetRosterAsync` branches are EXCLUSIVE — admin/staff callers get only the currently-online list and never reach the parent branch. spikerj is both admin and parent (of toddcan, prod's only minor), so when the child's presence key had lapsed the roster was empty and the child never appeared. Spec says parents ALWAYS see their kids. Fix: make the roster additive — staff/admin online-users ∪ own children (always listed) ∪ (child→parent), deduped with family relationships winning the label. Presence itself verified healthy (both users' `messaging-presence:*` keys live in Redis). **2. Chat shows generic icons instead of profile pictures.** Both test users have `AvatarGridFsId: null` but `ProfileImageId` set — the normal profile-picture flow populates `ProfileImageId`/`Images`, while `GET api/profile/{userId}/avatar` and the messaging DTOs only consult `AvatarGridFsId`. Fix: `GetAvatarQueryHandler` falls back `AvatarGridFsId ?? ProfileImageId` (same GridFS service; `images/{imageId}` is already AllowAnonymous, so no new exposure), and messaging DTOs use the same coalesce for their has-avatar indicator. Both fixes backend-only; frontend already renders the image whenever the indicator is non-null.
spikerj commented 2026-07-21 16:54:41 +00:00
Author
Owner
Copy Link
Copy Source

Correction shipped in backend PR #442: the #441 avatar coalesce passed ProfileImageId (a GUID referencing Images[]) straight to storage, which would 500 on ObjectId.Parse for gallery-picture users — GetAvatarImageKey now resolves the entry's real storage key. Roster fix from #441 is unaffected.

Correction shipped in backend PR #442: the #441 avatar coalesce passed ProfileImageId (a GUID referencing Images[]) straight to storage, which would 500 on ObjectId.Parse for gallery-picture users — GetAvatarImageKey now resolves the entry's real storage key. Roster fix from #441 is unaffected.
spikerj commented 2026-07-21 18:41:29 +00:00
Author
Owner
Copy Link
Copy Source

Resolved across spikersoft-backend PR #441 (roster additive buckets — merged) and PR #442 (corrected avatar-key resolution — merged + deployed; verified live: both test users' avatars now serve 200 with correct bytes). Closing.

Resolved across spikersoft-backend PR #441 (roster additive buckets — merged) and PR #442 (corrected avatar-key resolution — merged + deployed; verified live: both test users' avatars now serve 200 with correct bytes). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#770