Library tsconfig.spec rootDir: "src" blocks cross-library-importing unit tests (38 libs) #789
Assignees
spikerj (Joseph Spiker)
Clear assignees
spikerj (Joseph Spiker)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: spikerj/spikersoft-issues#789
Reference in New Issue
Block a user
Problem
38 library
tsconfig.spec.jsonfiles set"rootDir": "src", while 37 (the working majority) set"rootDir": "../..". A restrictiverootDir: "src"makes the Angular@angular/build:unit-testcompiler reject any spec that (transitively) imports source from another library — e.g.@spikersoft/environment,@spikersoft/models— withTS6059: File ... is not under rootDir '<lib>/src'.Impact
Any service in these libraries that imports cross-library source (most import
@spikersoft/environment) cannot be unit-tested at all. The libraries look "tested" only because their scaffolded smoke spec imports nothing. This silently caps achievable coverage across ~half the workspace. Surfaced while adding real specs during the frontend coverage push (learn.spikersoft.com, 14.6% baseline).Fix
Change
"rootDir": "src"→"rootDir": "../.."in each affectedtsconfig.spec.json(the established working convention — low-risk, mechanical).dev-tools-ipv4is already fixed in the coverage PR that surfaced this (unblocks its ipv4.service spec). The remaining 37 need a dedicated sweep PR verifying eachnx test <lib>stays green.Affected libraries (rootDir: "src")
domain/blog/tsconfig.spec.jsondomain/geo/tsconfig.spec.jsonfeatures/dev-tools-blockly/tsconfig.spec.jsonfeatures/dev-tools-common-commands-helper/tsconfig.spec.jsonfeatures/dev-tools-conversions-monaco/tsconfig.spec.jsonfeatures/dev-tools-decompiler/tsconfig.spec.jsonfeatures/dev-tools-diagram/tsconfig.spec.jsonfeatures/dev-tools-difference/tsconfig.spec.jsonfeatures/dev-tools-image-to-avif/tsconfig.spec.jsonfeatures/dev-tools-img-to-ico/tsconfig.spec.jsonfeatures/dev-tools-qr-code/tsconfig.spec.jsonfeatures/dev-tools-quick-type/tsconfig.spec.jsonmarks-site-models/tsconfig.spec.jsonplatform/avif-encoder/tsconfig.spec.jsonplatform/content-locale/tsconfig.spec.jsonplatform/intro-launching/tsconfig.spec.jsonplatform/intro-tour/tsconfig.spec.jsonplatform/lesson-catalog/tsconfig.spec.jsonplatform/loading/tsconfig.spec.jsonplatform/monaco-editor/tsconfig.spec.jsonplatform/pyodide-runtime/tsconfig.spec.jsonplatform/step-debugger-core/tsconfig.spec.jsonplatform/tool-file-menu/tsconfig.spec.jsonplatform/tool-storage/tsconfig.spec.jsonshared/api-config/tsconfig.spec.jsonshared/js-formatting-options/tsconfig.spec.jsonshared/lesson-platform/tsconfig.spec.jsonshared/save-load-dialogs/tsconfig.spec.jsonshared/utils/crc32/tsconfig.spec.jsonspikersoft-environment/tsconfig.spec.jsonspikersoft-models/tsconfig.spec.jsonspikersoft-theme/tsconfig.spec.jsonui/avatar-stack/tsconfig.spec.jsonui/confirm-dialog/tsconfig.spec.jsonui/destination-chips/tsconfig.spec.jsonui/mrz-crop/tsconfig.spec.jsonui/user-picker/tsconfig.spec.jsonBoard-sweep status (2026-07-22): partial — angular PR #526 (merged,
9ab22f04, on master) fixed therootDirfor exactly ONE library (features/dev-tools-ipv4, the one whose new ipv4 coverage it was blocking). 33 libraries still carry"rootDir": "src"intsconfig.spec.json(verified by grep on current master), so any cross-library-importing spec in those remains blocked. Remaining work: the sweep across the other 33 (mechanical, same one-line change), plus updating the workspace-plugin library generator template so new libs don't regress — note #742 is already open against that generator for the^undefinedpeers bug; both template fixes could land together. Leaving open.Resolved across spikersoft-angular PR #526 (dev-tools-ipv4, merged) and PR #528 (the remaining 37 libraries, merged to
master). Each library’stsconfig.spec.jsonrootDirnow resolves tolibraries/using the depth-correct relative path (depth-1.., depth-2../.., depth-3../../..). Verifiednx run-many --target=testgreen across all affected projects. Closing.