JsonPacketSerializer: EntityMovedEvent serialize throws NotSupportedException (JsonElement leak) #795

New Issue

2026-07-22T08:25:38Z

spikerj commented

2026-07-22 08:25:38 +00:00

Summary

JsonPacketSerializer.SerializeEvents throws NotSupportedException when given an EntityMovedEvent under AoT/source-generated STJ.

Root cause

In SerializeEventToDict, the EntityMovedEvent arm is the only case that does:

dict = JsonSerializer.Deserialize<Dictionary<string, object?>>(json1, GameServerJsonContext.Default.DictionaryStringObject) ?? dict;

leaving JsonElement values in the dictionary. Every other event arm uses ConvertJsonToDictionary, which unwraps to primitives.

When SerializeEvents then writes List<Dictionary<string, object?>> via GameServerJsonContext, AoT rejects JsonElement.

Repro

Pinned characterization test: JsonPacketSerializerSwitchCoverageTests.SerializeEvents_EntityMovedEvent_ThrowsNotSupported_DueToJsonElementLeak on branch test/coverage-wave-2026-07 / PR #454.

Fix

Change the EntityMovedEvent arm to use ConvertJsonToDictionary(json1) like the sibling cases.

Impact

JSON (browser/debug) clients cannot receive entity-moved events; MessagePack path is unaffected.

## Summary `JsonPacketSerializer.SerializeEvents` throws `NotSupportedException` when given an `EntityMovedEvent` under AoT/source-generated STJ. ## Root cause In `SerializeEventToDict`, the `EntityMovedEvent` arm is the only case that does: ```csharp dict = JsonSerializer.Deserialize<Dictionary<string, object?>>(json1, GameServerJsonContext.Default.DictionaryStringObject) ?? dict; ``` leaving `JsonElement` values in the dictionary. Every other event arm uses `ConvertJsonToDictionary`, which unwraps to primitives. When `SerializeEvents` then writes `List<Dictionary<string, object?>>` via `GameServerJsonContext`, AoT rejects `JsonElement`. ## Repro Pinned characterization test: `JsonPacketSerializerSwitchCoverageTests.SerializeEvents_EntityMovedEvent_ThrowsNotSupported_DueToJsonElementLeak` on branch `test/coverage-wave-2026-07` / PR #454. ## Fix Change the `EntityMovedEvent` arm to use `ConvertJsonToDictionary(json1)` like the sibling cases. ## Impact JSON (browser/debug) clients cannot receive entity-moved events; MessagePack path is unaffected.

spikerj referenced this issue

2026-07-29 18:20:32 +00:00

wasm-voxel AES is broken — round function missing, keystream is input/IV-independent (not real AES) #811

spikerj referenced this issue

2026-07-29 18:20:46 +00:00

PathManager.GetCachedObstacles always empty — CollectObstaclesInPlace never fills _obstacleArrayBuffer #808

spikerj referenced this issue

2026-07-29 18:21:03 +00:00

ElementRegistry incompatibility lists reference unregistered elements (H→F/Cl, O→Na/K) #792

spikerj referenced this issue

2026-07-29 18:21:14 +00:00

shockwave_fire spell combo can never trigger — un-normalized case in GetComboType #794