spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

FileValidationService: outer catch NullRefs when fileData is null #797

New Issue
Closed
opened 2026-07-22 09:14:58 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-22 09:14:58 +00:00
Owner
Copy link
Copy source

Summary

ValidateDotNetAssembly outer catch logs with fileData.FileName. If fileData itself is null (or the failure path NRE'd before assignment), the catch throws a second NullReferenceException instead of returning FileValidationResult.Failure.

Repro

Pinned characterization: FileValidationServiceTests.ValidateDotNetAssembly_NullFileData_ThrowsInsteadOfFailing on PR #454 / test/coverage-wave-2026-07.

Fix

Use null-conditional in the log (fileData?.FileName) and/or guard fileData is null at method entry.

Impact

Unexpected null DTO crashes the call site instead of a structured validation failure.

## Summary `ValidateDotNetAssembly` outer `catch` logs with `fileData.FileName`. If `fileData` itself is null (or the failure path NRE'd before assignment), the catch throws a second `NullReferenceException` instead of returning `FileValidationResult.Failure`. ## Repro Pinned characterization: `FileValidationServiceTests.ValidateDotNetAssembly_NullFileData_ThrowsInsteadOfFailing` on PR #454 / `test/coverage-wave-2026-07`. ## Fix Use null-conditional in the log (`fileData?.FileName`) and/or guard `fileData is null` at method entry. ## Impact Unexpected null DTO crashes the call site instead of a structured validation failure.
spikerj commented 2026-08-07 13:46:06 +00:00
Author
Owner
Copy link
Copy source

Migrated to spikerj/spikersoft-backend#530 as part of the umbrella-tracker breakup.

Verified 2026-08-07 against spikersoft-backend@98102023.
Status: not started.

Closing here. Work now lives in the repo that holds the fix, so fixes #530 in a PR will auto-close it on merge. The umbrella tracker keeps cross-repo epics only.

— Opus 5 Agent

Migrated to **spikerj/spikersoft-backend#530** as part of the umbrella-tracker breakup. Verified 2026-08-07 against ``spikersoft-backend@98102023``. Status: not started. Closing here. Work now lives in the repo that holds the fix, so `fixes #530` in a PR will auto-close it on merge. The umbrella tracker keeps cross-repo epics only. — Opus 5 Agent
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#797