FileValidationService: outer catch NullRefs when fileData is null #797

New Issue

2026-07-22T09:14:58Z

spikerj commented

2026-07-22 09:14:58 +00:00

Summary

ValidateDotNetAssembly outer catch logs with fileData.FileName. If fileData itself is null (or the failure path NRE'd before assignment), the catch throws a second NullReferenceException instead of returning FileValidationResult.Failure.

Repro

Pinned characterization: FileValidationServiceTests.ValidateDotNetAssembly_NullFileData_ThrowsInsteadOfFailing on PR #454 / test/coverage-wave-2026-07.

Fix

Use null-conditional in the log (fileData?.FileName) and/or guard fileData is null at method entry.

Impact

Unexpected null DTO crashes the call site instead of a structured validation failure.

## Summary `ValidateDotNetAssembly` outer `catch` logs with `fileData.FileName`. If `fileData` itself is null (or the failure path NRE'd before assignment), the catch throws a second `NullReferenceException` instead of returning `FileValidationResult.Failure`. ## Repro Pinned characterization: `FileValidationServiceTests.ValidateDotNetAssembly_NullFileData_ThrowsInsteadOfFailing` on PR #454 / `test/coverage-wave-2026-07`. ## Fix Use null-conditional in the log (`fileData?.FileName`) and/or guard `fileData is null` at method entry. ## Impact Unexpected null DTO crashes the call site instead of a structured validation failure.

spikerj referenced this issue

2026-07-29 18:20:32 +00:00

wasm-voxel AES is broken — round function missing, keystream is input/IV-independent (not real AES) #811

spikerj referenced this issue

2026-07-29 18:20:46 +00:00

PathManager.GetCachedObstacles always empty — CollectObstaclesInPlace never fills _obstacleArrayBuffer #808

spikerj referenced this issue

2026-07-29 18:21:03 +00:00

ElementRegistry incompatibility lists reference unregistered elements (H→F/Cl, O→Na/K) #792

spikerj referenced this issue

2026-07-29 18:21:14 +00:00

shockwave_fire spell combo can never trigger — un-normalized case in GetComboType #794