spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Boss.selectBossType() is a broken dead stub — throws on any call (empty bossTypesForFloor) #810

New Issue
Closed
opened 2026-07-23 04:59:07 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-23 04:59:07 +00:00
Owner
Copy link
Copy source

Bug (found via coverage wave 3, spikersoft-angular PR #551).

Boss.selectBossType(floor, rng) in projects/spikersoft/src/app/_components/_games/dungeon-crawler/models/boss.model.ts (~line 192) is an unfinished stub:

const bossTypesForFloor = [
  // Get 3 boss types for this floor
];
const selectedType = bossTypesForFloor[Math.floor(rng() * bossTypesForFloor.length)];
selectedType.name = this.translate(selectedType.translationKey); // TypeError: selectedType is undefined

bossTypesForFloor is always [], so selectedType is undefined and the next line throws Cannot set properties of undefined (setting name). The method can never succeed.

Currently dead — no caller (grep .selectBossType( finds none); the constructor uses the standalone selectRandomBossType(floor, rng) from boss-type.model.ts instead. So no runtime breakage today, but the method is a latent trap if anything ever calls it.

Fix: either delete the dead method, or implement it (populate bossTypesForFloor from getBossTypesForFloor(floor) and guard the empty case) and route the constructor through it.

Pinned as a characterization test in PR #551 (boss.model.spec.ts) asserting it currently throws, referencing this ticket; update when fixed.

**Bug (found via coverage wave 3, spikersoft-angular PR #551).** `Boss.selectBossType(floor, rng)` in `projects/spikersoft/src/app/_components/_games/dungeon-crawler/models/boss.model.ts` (~line 192) is an unfinished stub: ```ts const bossTypesForFloor = [ // Get 3 boss types for this floor ]; const selectedType = bossTypesForFloor[Math.floor(rng() * bossTypesForFloor.length)]; selectedType.name = this.translate(selectedType.translationKey); // TypeError: selectedType is undefined ``` `bossTypesForFloor` is always `[]`, so `selectedType` is `undefined` and the next line throws `Cannot set properties of undefined (setting name)`. The method can never succeed. Currently **dead** — no caller (`grep .selectBossType(` finds none); the constructor uses the standalone `selectRandomBossType(floor, rng)` from `boss-type.model.ts` instead. So no runtime breakage today, but the method is a latent trap if anything ever calls it. **Fix:** either delete the dead method, or implement it (populate `bossTypesForFloor` from `getBossTypesForFloor(floor)` and guard the empty case) and route the constructor through it. Pinned as a characterization test in PR #551 (`boss.model.spec.ts`) asserting it currently throws, referencing this ticket; update when fixed.
spikerj commented 2026-08-07 13:47:26 +00:00
Author
Owner
Copy link
Copy source

Migrated to spikerj/spikersoft-angular#636 as part of the umbrella-tracker breakup.

Verified 2026-08-07 against the synced default branch.

  • Code: spikersoft-angular@8e5a4048 — still broken. projects/spikersoft/src/app/_components/_games/dungeon-crawler/models/boss.model.ts:194-199 still has the empty const bossTypesForFloor = [ /* Get 3 boss types for this floor */ ]; followed by an unguarded index and selectedType.name = ....
  • Live: Dead code — no caller (selectRandomBossType from boss-type.model.ts is used instead), so no runtime symptom to probe.
  • Remaining: Delete the dead method, or implement it (populate from getBossTypesForFloor(floor), guard the empty case) and route the constructor through it. Then update the characterization test in boss.model.spec.ts that currently asserts it throws.

Status: still broken — full detail carried over to the new issue.

Closing here. Work now lives in the repo that holds the fix, so fixes #636 in a PR will
auto-close it on merge. The umbrella tracker keeps cross-repo epics only.

— Opus 5 Agent

Migrated to **spikerj/spikersoft-angular#636** as part of the umbrella-tracker breakup. Verified 2026-08-07 against the synced default branch. - **Code:** `spikersoft-angular@8e5a4048` — still broken. `projects/spikersoft/src/app/_components/_games/dungeon-crawler/models/boss.model.ts:194-199` still has the empty `const bossTypesForFloor = [ /* Get 3 boss types for this floor */ ];` followed by an unguarded index and `selectedType.name = ...`. - **Live:** Dead code — no caller (`selectRandomBossType` from `boss-type.model.ts` is used instead), so no runtime symptom to probe. - **Remaining:** Delete the dead method, or implement it (populate from `getBossTypesForFloor(floor)`, guard the empty case) and route the constructor through it. Then update the characterization test in `boss.model.spec.ts` that currently asserts it throws. Status: still broken — full detail carried over to the new issue. Closing here. Work now lives in the repo that holds the fix, so `fixes #636` in a PR will auto-close it on merge. The umbrella tracker keeps cross-repo epics only. — Opus 5 Agent
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#810