spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

Angular master e2e-anonymous RED since #827 PR #564: /sponsor/donate-family/:familyKey unclassified in route-manifest → publish skipped, frontend not deploying #828

New Issue
Closed
opened 2026-07-24 18:56:45 +00:00 by spikerj · 2 comments
spikerj commented 2026-07-24 18:56:45 +00:00
Owner
Copy Link
Copy Source

Symptom

e2e-anonymous has been RED on spikersoft-angular master since the #827 frontend merge (PR #564, run 18112 @ 2026-07-24 17:52Z) and again on every master run since. Because publish is gated on the e2e jobs, the publish job has been SKIPPED on every master run since 17:47Z — learn.spikersoft.com has not been redeployed.

Verified live: the deployed bundle main-VSL3ATV3.js on https://learn.spikersoft.com contains sponsor/family/:family, sponsor/fund/:code, sponsor/donate-org … but no sponsor/donate-family, confirming production is still running a pre-#564 build. The backend half of #827 did deploy (GET /api/sponsor/family-funds/{familyKey} returns 200 live).

Root cause

PR #564 added sponsor/donate-family/:familyKey to projects/spikersoft/src/routes.ts but did not classify it in e2e/support/route-manifest.ts, so route-coverage.spec.ts fails twice:

Error: routes declared in routes.ts but missing from e2e/support/route-manifest.ts — classify them
  + { access: "public", guards: [], path: "/sponsor/donate-family/:familyKey" }

Error: route coverage 29.2% fell below the 'anonymousOnly' ratchet baseline 29.5%
  Expected: >= 29.5   Received: 29.2

This is the same class as #819 (closed) and the documented exception (2) in e2e/support/coverage-baseline.json: adding a param route that needs a live id is inherently non-walkable (skipWalk), so it grows the declared denominator with no numerator gain and the ratio dips even though absolute coverage is unchanged.

Fix

  1. Add to e2e/support/route-manifest.ts:
    { path: "/sponsor/donate-family/:familyKey", url: "/sponsor", access: "public", skipWalk: true, note: "needs a live family key; reached from the family card's Sponsor button on the /sponsor list" }
  2. Re-derive BOTH ratchet baselines from the new totals (denominator 105 -> 106, walked unchanged) and record the math in the baseline comment, per the file's own rule:
    • anonymous 31/105 = 29.5 -> 31/106 = 29.2
    • credentialed 69/105 = 65.7 -> 69/106 = 65.1

Prevention

Same gap #824 describes for nx build: a route added without a manifest entry is only caught post-merge, because the e2e jobs that catch it are not required for merge. Worth folding into #824's CI-gating work.

## Symptom `e2e-anonymous` has been RED on `spikersoft-angular` master since the #827 frontend merge (PR #564, run 18112 @ 2026-07-24 17:52Z) and again on every master run since. Because `publish` is gated on the e2e jobs, **the `publish` job has been SKIPPED on every master run since 17:47Z — learn.spikersoft.com has not been redeployed.** Verified live: the deployed bundle `main-VSL3ATV3.js` on https://learn.spikersoft.com contains `sponsor/family/:family`, `sponsor/fund/:code`, `sponsor/donate-org` … but **no** `sponsor/donate-family`, confirming production is still running a pre-#564 build. The backend half of #827 *did* deploy (`GET /api/sponsor/family-funds/{familyKey}` returns 200 live). ## Root cause PR #564 added `sponsor/donate-family/:familyKey` to `projects/spikersoft/src/routes.ts` but did not classify it in `e2e/support/route-manifest.ts`, so `route-coverage.spec.ts` fails twice: ``` Error: routes declared in routes.ts but missing from e2e/support/route-manifest.ts — classify them + { access: "public", guards: [], path: "/sponsor/donate-family/:familyKey" } Error: route coverage 29.2% fell below the 'anonymousOnly' ratchet baseline 29.5% Expected: >= 29.5 Received: 29.2 ``` This is the same class as #819 (closed) and the documented **exception (2)** in `e2e/support/coverage-baseline.json`: adding a param route that needs a live id is inherently non-walkable (`skipWalk`), so it grows the declared denominator with no numerator gain and the ratio dips even though absolute coverage is unchanged. ## Fix 1. Add to `e2e/support/route-manifest.ts`: `{ path: "/sponsor/donate-family/:familyKey", url: "/sponsor", access: "public", skipWalk: true, note: "needs a live family key; reached from the family card's Sponsor button on the /sponsor list" }` 2. Re-derive BOTH ratchet baselines from the new totals (denominator 105 -> 106, walked unchanged) and record the math in the baseline comment, per the file's own rule: - anonymous 31/105 = 29.5 -> 31/106 = **29.2** - credentialed 69/105 = 65.7 -> 69/106 = **65.1** ## Prevention Same gap #824 describes for `nx build`: a route added without a manifest entry is only caught post-merge, because the e2e jobs that catch it are not required for merge. Worth folding into #824's CI-gating work.
spikerj commented 2026-07-24 18:58:41 +00:00
Author
Owner
Copy Link
Copy Source

Fix up in spikersoft-angular PR #568 (fix/828-donate-family-route-manifest): classifies /sponsor/donate-family/:familyKey as public + skipWalk and re-derives both ratchet baselines (anonymous 29.5 → 29.2, credentialed 65.7 → 65.1) with the math recorded in coverage-baseline.json as the second instance of documented exception (2). Awaiting CI.

— Opus 5 Agent

Fix up in spikersoft-angular **PR #568** (`fix/828-donate-family-route-manifest`): classifies `/sponsor/donate-family/:familyKey` as public + `skipWalk` and re-derives both ratchet baselines (anonymous 29.5 → 29.2, credentialed 65.7 → 65.1) with the math recorded in `coverage-baseline.json` as the second instance of documented exception (2). Awaiting CI. — Opus 5 Agent
spikerj commented 2026-07-24 19:23:49 +00:00
Author
Owner
Copy Link
Copy Source

Fixed and verified end to end. spikersoft-angular PR #568 merged to master (dd34b0a4).

  • PR #568's own e2e-anonymous passed at 19:05Z — the first green run of that job since 17:52Z.
  • Master run 18124 on the merge commit is green across the board: compute_version, build, e2e-anonymous, e2e-smoke, test-and-lint all success, and publish ran (success) instead of being skipped — the deploy gate this ticket was about.
  • Production redeployed: learn.spikersoft.com now serves main-SRPMVC66.js (was main-VSL3ATV3.js), and the new bundle contains sponsor/donate-family/:family. The frontend deploy backlog is cleared.

Closing.

— Opus 5 Agent

Fixed and verified end to end. spikersoft-angular PR #568 merged to master (`dd34b0a4`). - PR #568's own `e2e-anonymous` passed at 19:05Z — the first green run of that job since 17:52Z. - Master run 18124 on the merge commit is green across the board: `compute_version`, `build`, `e2e-anonymous`, `e2e-smoke`, `test-and-lint` all success, and **`publish` ran (success) instead of being skipped** — the deploy gate this ticket was about. - Production redeployed: learn.spikersoft.com now serves `main-SRPMVC66.js` (was `main-VSL3ATV3.js`), and the new bundle contains `sponsor/donate-family/:family`. The frontend deploy backlog is cleared. Closing. — Opus 5 Agent
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#828