spikersoft-artpipe has no PR CI — its whole pytest suite is ungated #864

New Issue

2026-07-27T02:36:20Z

spikerj commented

2026-07-27 02:36:20 +00:00

spikersoft-artpipe has a real pytest suite under tests/ — 30+ files, deliberately
torch-free where it can be — and nothing ever runs it.

.gitea/workflows/model-env-images.yml is the repo's only workflow, and it triggers on
push to main (paths src/**, models/**, docker/**, …) to build env images. There is
no pull_request trigger anywhere in the repo, so:

a PR against spikersoft-artpipe gets zero status checks — nothing to go red, so
nothing signals a break;
pytest tests/ has never gated a merge;
the only feedback on a bad change is the env-image build failing later on main, which
says nothing about whether the Python logic is correct.

This came up filing #863: the concept per-step progress change (PR #42) shipped with new
tests that no automation has executed. The helper was verified by hand, which is not a
substitute.

What it needs

A pull_request workflow that installs the package and runs the torch-free subset:

pytest tests/ -m "not gpu and not blender and not e2e" — the markers already exist in
pyproject.toml, so the split is free.
No GPU runner required for that subset; it is the same philosophy
tests/test_concept_run_params.py was written to.
Keep the existing main-push env-image build exactly as it is.

Worth checking at the same time whether the other two repos' PR gates cover everything
they claim to, since this one silently covered nothing.

`spikersoft-artpipe` has a real pytest suite under `tests/` — 30+ files, deliberately torch-free where it can be — and **nothing ever runs it**. `.gitea/workflows/model-env-images.yml` is the repo's only workflow, and it triggers on push to `main` (paths `src/**`, `models/**`, `docker/**`, …) to build env images. There is no `pull_request` trigger anywhere in the repo, so: - a PR against `spikersoft-artpipe` gets **zero** status checks — nothing to go red, so nothing signals a break; - `pytest tests/` has never gated a merge; - the only feedback on a bad change is the env-image build failing later on `main`, which says nothing about whether the Python logic is correct. This came up filing #863: the concept per-step progress change (PR #42) shipped with new tests that no automation has executed. The helper was verified by hand, which is not a substitute. ## What it needs A `pull_request` workflow that installs the package and runs the torch-free subset: - `pytest tests/ -m "not gpu and not blender and not e2e"` — the markers already exist in `pyproject.toml`, so the split is free. - No GPU runner required for that subset; it is the same philosophy `tests/test_concept_run_params.py` was written to. - Keep the existing `main`-push env-image build exactly as it is. Worth checking at the same time whether the other two repos' PR gates cover everything they claim to, since this one silently covered nothing.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#864