spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

Destination background images: anonymous /destination-images MediaRoute from MinIO assets bucket #869

New Issue
Closed
opened 2026-07-27 14:29:24 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-27 14:29:24 +00:00
Owner
Copy Link
Copy Source

Part of #868 (PR-1, backend).

Add to the MediaRoute table (SpikerSoft.Api/Extensions/ServiceCollectionExtensions.cs:~1136):

new MediaRoute("/destination-images", sp.GetRequiredKeyedService<IObjectStore>("assets"), "destinations", ServeUnknownTypes: false)

  • Extend MediaRoute/S3MediaFallbackMiddleware with an optional CacheControl field; set public, max-age=604800 here (images are immutable-by-name). Existing routes keep current behavior.
  • GET/HEAD only, 404 fail-soft, path hardening — all inherited from the middleware; add tests mirroring the existing middleware suite for the new prefix + cache header.
  • Serves objects Joey uploads to assets/destinations/{code}.avif (spec in #868).
Part of #868 (PR-1, backend). Add to the `MediaRoute` table (`SpikerSoft.Api/Extensions/ServiceCollectionExtensions.cs:~1136`): `new MediaRoute("/destination-images", sp.GetRequiredKeyedService<IObjectStore>("assets"), "destinations", ServeUnknownTypes: false)` - Extend `MediaRoute`/`S3MediaFallbackMiddleware` with an optional `CacheControl` field; set `public, max-age=604800` here (images are immutable-by-name). Existing routes keep current behavior. - GET/HEAD only, 404 fail-soft, path hardening — all inherited from the middleware; add tests mirroring the existing middleware suite for the new prefix + cache header. - Serves objects Joey uploads to `assets/destinations/{code}.avif` (spec in #868).
spikerj commented 2026-07-29 15:28:25 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #497 (the consolidated family-card epic PR, merged to master, c8f692d7). The standalone PR #493 was closed unmerged in favour of that consolidation. Verified against origin/master:

  • S3MediaFallbackMiddleware.cs:13 — MediaRoute(..., string? CacheControl = null); header emitted at :83-85.
  • ServiceCollectionExtensions.cs:1153 — route registered against the keyed "assets" store with prefix destinations, ServeUnknownTypes: false, CacheControl: "public, max-age=604800".
  • Tests in S3MediaFallbackMiddlewareTests.cs: serves with the header (:201), no header on miss (:223), existing routes unchanged (:244), plus GET/HEAD, path-traversal and fail-soft coverage at :94, :171, :187.

Closing.

Resolved in spikersoft-backend PR #497 (the consolidated family-card epic PR, merged to `master`, `c8f692d7`). The standalone PR #493 was closed unmerged in favour of that consolidation. Verified against `origin/master`: - `S3MediaFallbackMiddleware.cs:13` — `MediaRoute(..., string? CacheControl = null)`; header emitted at `:83-85`. - `ServiceCollectionExtensions.cs:1153` — route registered against the keyed `"assets"` store with prefix `destinations`, `ServeUnknownTypes: false`, `CacheControl: "public, max-age=604800"`. - Tests in `S3MediaFallbackMiddlewareTests.cs`: serves with the header (`:201`), no header on miss (`:223`), existing routes unchanged (`:244`), plus GET/HEAD, path-traversal and fail-soft coverage at `:94`, `:171`, `:187`. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#869