fishing game works? #89

Closed
opened 2026-05-08 22:48:29 +00:00 by Zhekrom · 3 comments

The screen remains blank. I'm not certain whether the feature is implemented, and it also lacks an icon in the dropdown menu.

The screen remains blank. I'm not certain whether the feature is implemented, and it also lacks an icon in the dropdown menu.
Author

“The screen stays blank.

“The screen stays blank.
Owner

Triage (code review, no change yet): the fishing game is not implemented — the report of a blank screen is expected behavior given the current code.

Findings in spikersoft-angular:

  • _games/fishing-game/fishing-game.component.html renders only a placeholder string: {{ t("pages.stubs.fishingGame") }}.
  • _games/fishing-game/fishing-game.component.ts is a mock-state shell; the entire game engine (scenes, reel, progress, fish entities) exists only as a large commented-out block.
  • There is a home-screen entry point (.fishing-icon in home.component.html/.scss), but no route is registered for the fishing game in routes.ts, which is why navigating to it shows a blank/stub screen and the dropdown lacks proper iconography.

This is a feature gap rather than a fixable bug, so it needs a product decision: either (a) build out the fishing game (sizable new feature), or (b) descope it for now — remove the home icon/stub so it's not discoverable — and track the build-out separately. Holding for direction before making changes.

Triage (code review, no change yet): the fishing game is **not implemented** — the report of a blank screen is expected behavior given the current code. Findings in `spikersoft-angular`: - `_games/fishing-game/fishing-game.component.html` renders only a placeholder string: `{{ t("pages.stubs.fishingGame") }}`. - `_games/fishing-game/fishing-game.component.ts` is a mock-state shell; the entire game engine (scenes, reel, progress, fish entities) exists only as a large commented-out block. - There is a home-screen entry point (`.fishing-icon` in `home.component.html`/`.scss`), but **no route is registered** for the fishing game in `routes.ts`, which is why navigating to it shows a blank/stub screen and the dropdown lacks proper iconography. This is a feature gap rather than a fixable bug, so it needs a product decision: either (a) build out the fishing game (sizable new feature), or (b) descope it for now — remove the home icon/stub so it's not discoverable — and track the build-out separately. Holding for direction before making changes.
Owner

Descoped per decision: removed the home-screen fishing entry point so the unimplemented stub isn't discoverable, in spikersoft-angular PR #52 (removes the icon markup, its SCSS, and the now-unused MatTooltip import). The FishingGameComponent stub stays as unrouted dead code; the actual game build-out should be tracked as a separate feature request. Will close once PR #52 merges.

Descoped per decision: removed the home-screen fishing entry point so the unimplemented stub isn't discoverable, in `spikersoft-angular` PR #52 (removes the icon markup, its SCSS, and the now-unused MatTooltip import). The `FishingGameComponent` stub stays as unrouted dead code; the actual game build-out should be tracked as a separate feature request. Will close once PR #52 merges.
Sign in to join this conversation.