spikerj/spikersoft-issues
1
0 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Backend: POST api/recorded-routes/{id}/trim (epic #992) #993

New Issue
Closed
opened 2026-08-07 03:50:41 +00:00 by spikerj · 1 comment
spikerj commented 2026-08-07 03:50:41 +00:00
Owner
Copy link
Copy source

Part of epic #992. Lands first.

  • TrimRecordedRouteRequestDto {KeepStartIndex, KeepEndIndex, ExpectedPointCount?} in RecordedRouteDtos.cs.
  • New Commands/TrimRecordedRoute/ command + validator (shape rules only) + handler: load owner-scoped tracked summary (404 convention), load points doc, validate indices against deserialized array length (never summary PointCount), 409 RecordedRouteTrimConflictException on ExpectedPointCount mismatch, no-op short-circuit, inclusive slice + segment rebase, recompute via RouteStatsCalculator, ordered writes: delete analysis doc → replace PointsJson → update summary. Log ids/counts only — never coordinates.
  • Controller [HttpPost("{id}/trim")] (UpdateMetadata try/catch shape + Conflict catch); RecordedRouteMapper.ToDetailDto(route, points).
  • Tests: handler (slice/rebase/recompute/analysis-deleted, no-op, kept<2, out-of-range, 409, foreign-owner, partial-failure self-heal), validator, controller. Reuse GpsTraceBuilder; pin the shared trim fixture (apply+stats). Build SpikerSoft.UnitTests.slnf.
Part of epic #992. Lands first. - `TrimRecordedRouteRequestDto {KeepStartIndex, KeepEndIndex, ExpectedPointCount?}` in `RecordedRouteDtos.cs`. - New `Commands/TrimRecordedRoute/` command + validator (shape rules only) + handler: load owner-scoped tracked summary (404 convention), load points doc, validate indices against **deserialized array length** (never summary PointCount), 409 `RecordedRouteTrimConflictException` on ExpectedPointCount mismatch, no-op short-circuit, inclusive slice + segment rebase, recompute via `RouteStatsCalculator`, ordered writes: delete analysis doc → replace PointsJson → update summary. Log ids/counts only — never coordinates. - Controller `[HttpPost("{id}/trim")]` (UpdateMetadata try/catch shape + Conflict catch); `RecordedRouteMapper.ToDetailDto(route, points)`. - Tests: handler (slice/rebase/recompute/analysis-deleted, no-op, kept<2, out-of-range, 409, foreign-owner, partial-failure self-heal), validator, controller. Reuse `GpsTraceBuilder`; pin the shared trim fixture (apply+stats). Build `SpikerSoft.UnitTests.slnf`.
spikerj commented 2026-08-07 13:47:40 +00:00
Author
Owner
Copy link
Copy source

Verified complete 2026-08-07 — closing.

  • Code: spikersoft-backend@f8f402cd (PR #527, feat/recorded-route-trim-993, commit d2b81036) —
    • SpikerSoft.Api/Domain/Map/RecordedRoutes/RecordedRoutesController.cs:218 → [HttpPost("{id}/trim")]
    • SpikerSoft.Business/Domain/Map/RecordedRoutes/Commands/TrimRecordedRoute/ — TrimRecordedRouteCommand.cs, TrimRecordedRouteCommandHandler.cs, TrimRecordedRouteCommandValidator.cs
    • SpikerSoft.Data/DTOs/RecordedRouteDtos.cs — TrimRecordedRouteRequestDto
    • Tests: SpikerSoft.Business.Tests/Domain/Map/RecordedRoutes/Commands/TrimRecordedRouteCommandHandlerTests.cs + …ValidatorTests.cs, plus SpikerSoft.API.Tests/Controllers/RecordedRoutesControllerTests.cs.
  • Live: unauthenticated POST https://api.spikersoft.com/api/recorded-routes/000000000000000000000000/trim → 401, while POST …/000000000000000000000000/bogusnothing → 404. The 401-vs-404 split proves the trim route is registered in the deployed API, not merely on master.
  • Shipped by: PR #527.

Not migrated: nothing left to do. (The iOS consumer, #994, is the piece still outstanding in this epic — migrated to spikerj/spikersoft-ios#16.)

— Opus 5 Agent

Verified complete 2026-08-07 — closing. - **Code:** `spikersoft-backend@f8f402cd` (PR #527, `feat/recorded-route-trim-993`, commit `d2b81036`) — - `SpikerSoft.Api/Domain/Map/RecordedRoutes/RecordedRoutesController.cs:218` → `[HttpPost("{id}/trim")]` - `SpikerSoft.Business/Domain/Map/RecordedRoutes/Commands/TrimRecordedRoute/` — `TrimRecordedRouteCommand.cs`, `TrimRecordedRouteCommandHandler.cs`, `TrimRecordedRouteCommandValidator.cs` - `SpikerSoft.Data/DTOs/RecordedRouteDtos.cs` — `TrimRecordedRouteRequestDto` - Tests: `SpikerSoft.Business.Tests/Domain/Map/RecordedRoutes/Commands/TrimRecordedRouteCommandHandlerTests.cs` + `…ValidatorTests.cs`, plus `SpikerSoft.API.Tests/Controllers/RecordedRoutesControllerTests.cs`. - **Live:** unauthenticated `POST https://api.spikersoft.com/api/recorded-routes/000000000000000000000000/trim` → **401**, while `POST …/000000000000000000000000/bogusnothing` → **404**. The 401-vs-404 split proves the trim route is registered in the **deployed** API, not merely on master. - **Shipped by:** PR #527. Not migrated: nothing left to do. (The iOS consumer, #994, is the piece still outstanding in this epic — migrated to spikerj/spikersoft-ios#16.) — Opus 5 Agent
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 epic
Cross-repo epic — children live in per-repo trackers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#993