spikerj opened issue spikerj/spikersoft-issues#697 2026-07-18 02:12:35 +00:00
[Maintainability] Fix CS8619 nullability mismatch on RabbitMQ message Headers (4 sites)
spikerj commented on issue spikerj/spikersoft-issues#696 2026-07-18 01:49:43 +00:00
[Infra][MinIO] Cut over book/ebook artifacts to MinIO as sole store (ebooks slice of #413) + fix inline-mirror pipeline stall

Phase 0 (partial) landed: backend PR #391 merged to master (merge 6ad002e2).

Added an opt-in per-operation timeout to S3ObjectStore (linked CancellationTokenSource), enabled at 120s…

spikerj opened issue spikerj/spikersoft-issues#696 2026-07-18 01:16:29 +00:00
[Infra][MinIO] Cut over book/ebook artifacts to MinIO as sole store (ebooks slice of #413) + fix inline-mirror pipeline stall
spikerj closed issue spikerj/spikersoft-issues#695 2026-07-18 00:02:55 +00:00
[Robustness] Fundraiser RecordSale QuantitySold has no upper bound — absurd values can overflow accumulated totals
spikerj commented on issue spikerj/spikersoft-issues#695 2026-07-18 00:02:55 +00:00
[Robustness] Fundraiser RecordSale QuantitySold has no upper bound — absurd values can overflow accumulated totals

Resolved in spikersoft-backend PR #390 (merged to master). Capped RecordSale QuantitySold at 1,000,000 in the validator so absurd values can't overflow the accumulated int total. 7 validator…

spikerj opened issue spikerj/spikersoft-issues#695 2026-07-17 23:50:58 +00:00
[Robustness] Fundraiser RecordSale QuantitySold has no upper bound — absurd values can overflow accumulated totals
spikerj commented on issue spikerj/spikersoft-issues#694 2026-07-17 23:29:30 +00:00
[Security] GeneratorBrands write endpoints allow any authenticated user to modify CRM reference data (#689 follow-up)

Resolved in spikersoft-backend PR #389 (merged to master). Gated GeneratorBrands POST/PUT/DELETE to [Authorize(Roles = "Admin,admin,Staff,staff")] (method-level; public GET reads preserved). 5…

spikerj closed issue spikerj/spikersoft-issues#694 2026-07-17 23:29:30 +00:00
[Security] GeneratorBrands write endpoints allow any authenticated user to modify CRM reference data (#689 follow-up)
spikerj opened issue spikerj/spikersoft-issues#694 2026-07-17 23:20:50 +00:00
[Security] GeneratorBrands write endpoints allow any authenticated user to modify CRM reference data (#689 follow-up)
spikerj closed issue spikerj/spikersoft-issues#692 2026-07-17 23:15:17 +00:00
[Security] Phone verification codes (OTP) written to logs at Information level
spikerj commented on issue spikerj/spikersoft-issues#692 2026-07-17 23:15:17 +00:00
[Security] Phone verification codes (OTP) written to logs at Information level

Resolved in spikersoft-backend PR #388 (merged to master). Removed the 6-digit OTP from both handlers' logs, including the webhook entry-point log (redacted via Is6DigitCode when an inbound SMS…

spikerj commented on issue spikerj/spikersoft-issues#693 2026-07-17 23:14:10 +00:00
[Security] TwilioController outbound endpoints are unauthenticated — SMS/call/lookup abuse & cost

Closing per maintainer guidance: the Twilio integration is implemented to spec — the outbound endpoints' access is controlled outside the controller code I reviewed (e.g. network/gateway…

spikerj closed issue spikerj/spikersoft-issues#693 2026-07-17 23:14:10 +00:00
[Security] TwilioController outbound endpoints are unauthenticated — SMS/call/lookup abuse & cost
spikerj opened issue spikerj/spikersoft-issues#693 2026-07-17 23:13:35 +00:00
[Security] TwilioController outbound endpoints are unauthenticated — SMS/call/lookup abuse & cost
spikerj commented on issue spikerj/spikersoft-issues#689 2026-07-17 23:09:50 +00:00
[Security] Gate the remaining Mark Wilson CRM controllers to staff/admin (#688 follow-up)

Resolved in spikersoft-backend PR #386 (merged to master). Gated the sibling CRM controllers (ServiceCalls/Labors/Parts/Milages/ServiceCallReasons) to `[Authorize(Roles = "Admin,admin,Staff,staff…

spikerj closed issue spikerj/spikersoft-issues#691 2026-07-17 23:09:50 +00:00
[Security] Pre-registration email verification code is brute-forceable — attempts counted but never enforced
spikerj commented on issue spikerj/spikersoft-issues#691 2026-07-17 23:09:50 +00:00
[Security] Pre-registration email verification code is brute-forceable — attempts counted but never enforced

Resolved in spikersoft-backend PR #387 (merged to master). Enforced a 5-attempt cap on the 6-digit email verification code before validation (reset on resend); the code is no longer brute-forceab…

spikerj closed issue spikerj/spikersoft-issues#689 2026-07-17 23:09:50 +00:00
[Security] Gate the remaining Mark Wilson CRM controllers to staff/admin (#688 follow-up)
spikerj opened issue spikerj/spikersoft-issues#692 2026-07-17 23:05:04 +00:00
[Security] Phone verification codes (OTP) written to logs at Information level
spikerj opened issue spikerj/spikersoft-issues#691 2026-07-17 23:00:05 +00:00
[Security] Pre-registration email verification code is brute-forceable — attempts counted but never enforced