Joseph Spiker

spikerj commented on issue spikerj/spikersoft-issues#662

2026-07-17 18:16:11 +00:00

Adopt Angular 22 / Nx 23.1 optimizations: OnPush burn-down, strictTemplates, migration-artifact cleanup

Resolved in spikersoft-angular PR #230 (merged to master 2026-07-17). All 55 Eager components converted to OnPush, strictTemplates enabled app-wide with all fallout fixed at root cause, 42…

spikerj closed issue spikerj/spikersoft-issues#671

2026-07-17 18:12:49 +00:00

RPC consumers NRE on null handler response (payload.GetType() in PublishReplyAsync) — CS8604

spikerj commented on issue spikerj/spikersoft-issues#671

2026-07-17 18:12:49 +00:00

RPC consumers NRE on null handler response (payload.GetType() in PublishReplyAsync) — CS8604

Resolved in spikersoft-backend PR #371 (merged to master). Guarded null handler response before the payload.GetType() deref in the Decompile, Notifications, and Embeddings RPC consumers so a…

spikerj closed issue spikerj/spikersoft-issues#670

2026-07-17 18:06:15 +00:00

fix(calendar-reminders): null BasicProperties.Headers NREs the reminder publish when tracing is inactive (CS8602)

spikerj commented on issue spikerj/spikersoft-issues#670

2026-07-17 18:06:15 +00:00

fix(calendar-reminders): null BasicProperties.Headers NREs the reminder publish when tracing is inactive (CS8602)

Resolved in spikersoft-backend PR #370 (merged to master). Initialized BasicProperties.Headers in the reminder publish so the business headers no longer NRE when tracing is inactive (StartActivit…

spikerj commented on issue spikerj/spikersoft-issues#667

2026-07-17 18:03:41 +00:00

chore: remove abandoned commented-out code blocks (S125)

Resolved in spikersoft-backend PR #366 (merged to master). Removed abandoned commented-out prototype code (S125) from Asset.cs, ToolsController.cs, HexatileGameManager.cs; comment-only…

spikerj closed issue spikerj/spikersoft-issues#667

2026-07-17 18:03:41 +00:00

chore: remove abandoned commented-out code blocks (S125)

spikerj closed issue spikerj/spikersoft-issues#669

2026-07-17 18:03:17 +00:00

fix(notifications): null Twilio VerificationCheck.Status causes NRE + dropped audit in 2FA verify (CS8602)

spikerj commented on issue spikerj/spikersoft-issues#669

2026-07-17 18:03:17 +00:00

fix(notifications): null Twilio VerificationCheck.Status causes NRE + dropped audit in 2FA verify (CS8602)

Resolved in spikersoft-backend PR #366 (merged to master). Guarded null Twilio VerificationCheck.Status (CS8602): fixed an NRE that turned valid 2FA results into INTERNAL_ERROR and silently…

spikerj opened issue spikerj/spikersoft-issues#671

2026-07-17 17:58:11 +00:00

RPC consumers NRE on null handler response (payload.GetType() in PublishReplyAsync) — CS8604

spikerj commented on issue spikerj/spikersoft-issues#668

2026-07-17 17:34:12 +00:00

test: convert BroadcastToPlayersInRange tests to async/await (xUnit1031)

Resolved in spikersoft-backend PR #366 (merged to master). Converted 18 blocking BroadcastToPlayersInRange tests to async Task + await (xUnit1031); all 34 cases pass, zero behavior change. All…

spikerj closed issue spikerj/spikersoft-issues#668

2026-07-17 17:34:04 +00:00

test: convert BroadcastToPlayersInRange tests to async/await (xUnit1031)

spikerj commented on issue spikerj/spikersoft-issues#668

2026-07-17 17:34:04 +00:00

test: convert BroadcastToPlayersInRange tests to async/await (xUnit1031)

Resolved in spikersoft-backend PR #368 (merged to master). Converted the 18 blocking BroadcastToPlayersInRange tests to async Task + await (xUnit1031); all 34 cases pass, zero behavior change.…

spikerj opened issue spikerj/spikersoft-issues#670

2026-07-17 17:24:32 +00:00

fix(calendar-reminders): null BasicProperties.Headers NREs the reminder publish when tracing is inactive (CS8602)

spikerj opened issue spikerj/spikersoft-issues#669

2026-07-17 17:16:35 +00:00

fix(notifications): null Twilio VerificationCheck.Status causes NRE + dropped audit in 2FA verify (CS8602)

spikerj opened issue spikerj/spikersoft-issues#668

2026-07-17 17:01:36 +00:00

test: convert BroadcastToPlayersInRange tests to async/await (xUnit1031)

spikerj opened issue spikerj/spikersoft-issues#667

2026-07-17 16:51:37 +00:00

chore: remove abandoned commented-out code blocks (S125)

spikerj commented on issue spikerj/spikersoft-issues#666

2026-07-17 16:44:35 +00:00

fix(data): cast null to nullable JsonSerializerOptions in EF value converters (CS8600, 66 findings)

Resolved in spikersoft-backend PR #366 (merged to master by spikerj). Changed all 98 EF value-converter casts in SpikerDbContext to (JsonSerializerOptions?)null; zero behavior change, CS8600…

spikerj closed issue spikerj/spikersoft-issues#666

2026-07-17 16:44:35 +00:00

fix(data): cast null to nullable JsonSerializerOptions in EF value converters (CS8600, 66 findings)

spikerj commented on issue spikerj/spikersoft-issues#665

2026-07-17 16:40:24 +00:00

fix(api): DecompileController drops request CancellationToken into MediatR (CA2016)

Resolved in spikersoft-backend PR #365 (merged to master). Forwarded the request CancellationToken to all four _mediator.Send calls in DecompileController; added a regression test asserting the…