spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug] Hiring: show menu for logged-out users; avoid Keycloak redirect for nav; keep backend protected #39

New Issue
Closed
opened 2026-04-29 06:08:52 +00:00 by spikerj · 1 comment
spikerj commented 2026-04-29 06:08:52 +00:00
Owner
Copy Link
Copy Source

Summary

When not logged in, users should still see the Hiring entry in the navigation/menu (hiring menu component option). Hiring-related data and actions should remain behind authenticated, protected backend endpoints.

Current behavior

Something in the current flow causes users to be redirected to the SpikerSoft Keycloak server when logged out (likely because a protected API or route guard runs too early or for the wrong scope).

Expected behavior

  1. Anonymous users can see the Hiring menu item and navigate to the appropriate public shell/page for hiring (or a landing state that explains login is required for application actions).
  2. Backend calls that require identity or privileged hiring data remain 401/403 protected — not replaced by full-app Keycloak redirects for merely viewing the menu or public framing.
  3. Separate explicit login when the user performs an action that requires auth (e.g. submit application), rather than surprising redirects from menu visibility checks.

Notes / acceptance

  • Hiring menu visible in nav when logged out
  • No unwanted Keycloak redirect solely from rendering or selecting the Hiring menu entry
  • Protected endpoints still enforce auth appropriately for sensitive operations

Area

Frontend navigation / route guards / API client interceptors vs. backend [Authorize] (or equivalent) for hiring flows.

## Summary When **not logged in**, users should still see the **Hiring** entry in the navigation/menu (hiring menu component option). Hiring-related **data and actions** should remain behind **authenticated, protected backend** endpoints. ## Current behavior Something in the current flow causes users to be **redirected to the SpikerSoft Keycloak** server when logged out (likely because a protected API or route guard runs too early or for the wrong scope). ## Expected behavior 1. **Anonymous users** can see the Hiring menu item and navigate to the appropriate public shell/page for hiring (or a landing state that explains login is required for application actions). 2. **Backend calls** that require identity or privileged hiring data remain **401/403 protected** — not replaced by full-app Keycloak redirects for merely viewing the menu or public framing. 3. Separate **explicit** login when the user performs an action that requires auth (e.g. submit application), rather than surprising redirects from menu visibility checks. ## Notes / acceptance - [ ] Hiring menu visible in nav when logged out - [ ] No unwanted Keycloak redirect solely from rendering or selecting the Hiring menu entry - [ ] Protected endpoints still enforce auth appropriately for sensitive operations ## Area Frontend navigation / route guards / API client interceptors vs. backend `[Authorize]` (or equivalent) for hiring flows.
spikerj commented 2026-05-05 04:02:20 +00:00
Author
Owner
Copy Link
Copy Source

Resolved -- Guarded getProfile() call behind keycloak.authenticated check in employment.component.ts so logged-out users no longer trigger a 401 → Keycloak redirect. Route was already accessible (no AuthGuard), menu link was already visible, and GetOpenPositions endpoint was already anonymous.

**Resolved** -- Guarded `getProfile()` call behind `keycloak.authenticated` check in `employment.component.ts` so logged-out users no longer trigger a 401 → Keycloak redirect. Route was already accessible (no AuthGuard), menu link was already visible, and `GetOpenPositions` endpoint was already anonymous.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#39