spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

Adopt Angular 22 / Nx 23.1 optimizations: OnPush burn-down, strictTemplates, migration-artifact cleanup #662

New Issue
Closed
opened 2026-07-17 16:18:50 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 16:18:50 +00:00
Owner
Copy Link
Copy Source

Post-upgrade adoption pass over the Angular 22.0 and Nx 23.1 changelogs (we were on latest versions but still carrying migration compat shims).

Scope (spikersoft-angular):

  • Convert all 55 components left on ChangeDetectionStrategy.Eager by the v22 migration to OnPush (zoneless-safe; minimal markForCheck/signal fixes where needed)
  • Enable strictTemplates on the main app + fix all resulting errors (several were real runtime bugs: dead mat-slider API in wasm-voxel block editor, map-tracker "use current location" buttons bound to nonexistent outputs, Google Maps pixelOffset needing a real Size, profile.totalCount vs wire field totalEarned)
  • Remove all 42 $safeNavigationMigration(...) template wrappers (adopt v22 ?. → undefined semantics)
  • Strip v22-migration nullishCoalescingNotNullable/optionalChainNotNullable suppressions from 119 tsconfigs (zero violations existed)
  • Migrate deprecated reportProgress → reportUploadProgress/reportDownloadProgress (2 call sites); keep withXhr() because PDF upload progress is consumed
  • Remove no-op prefetch on idle from two on immediate @defer blocks (new NG8021 diagnostic)
  • nx.json cache-input fixes: lint input pointed at nonexistent .eslintrc.json, production input missed eslint.config.cjs, empty sharedGlobals (tsconfig.base.json/browserslist changes didn't invalidate caches)
  • Audited router paramsInheritanceStrategy: 'always' default flip: no impact (no nested same-name params, no param iteration, no componentInputBinding)
Post-upgrade adoption pass over the Angular 22.0 and Nx 23.1 changelogs (we were on latest versions but still carrying migration compat shims). Scope (spikersoft-angular): - Convert all 55 components left on `ChangeDetectionStrategy.Eager` by the v22 migration to OnPush (zoneless-safe; minimal markForCheck/signal fixes where needed) - Enable `strictTemplates` on the main app + fix all resulting errors (several were real runtime bugs: dead mat-slider API in wasm-voxel block editor, map-tracker "use current location" buttons bound to nonexistent outputs, Google Maps `pixelOffset` needing a real `Size`, `profile.totalCount` vs wire field `totalEarned`) - Remove all 42 `$safeNavigationMigration(...)` template wrappers (adopt v22 `?.` → undefined semantics) - Strip v22-migration `nullishCoalescingNotNullable`/`optionalChainNotNullable` suppressions from 119 tsconfigs (zero violations existed) - Migrate deprecated `reportProgress` → `reportUploadProgress`/`reportDownloadProgress` (2 call sites); keep `withXhr()` because PDF upload progress is consumed - Remove no-op `prefetch on idle` from two `on immediate` @defer blocks (new NG8021 diagnostic) - nx.json cache-input fixes: lint input pointed at nonexistent `.eslintrc.json`, production input missed `eslint.config.cjs`, empty `sharedGlobals` (tsconfig.base.json/browserslist changes didn't invalidate caches) - Audited router `paramsInheritanceStrategy: 'always'` default flip: no impact (no nested same-name params, no param iteration, no componentInputBinding)
spikerj commented 2026-07-17 18:16:11 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-angular PR #230 (merged to master 2026-07-17). All 55 Eager components converted to OnPush, strictTemplates enabled app-wide with all fallout fixed at root cause, 42 $safeNavigationMigration wrappers and 119 tsconfig diagnostic suppressions removed, reportProgress migrated, nx.json cache inputs corrected, paramsInheritanceStrategy audit came back clean. Follow-ups tracked in #663 (quiz review endpoint) and #664 (root typecheck). Note: the e2e-anonymous CI failures on the merge run are a pre-existing backend outage (/api/sponsor/profiles and /api/geography/travel-stats returning 500 — same failure on pre-merge master run 8902), tracked separately. Closing.

Resolved in spikersoft-angular PR #230 (merged to `master` 2026-07-17). All 55 Eager components converted to OnPush, strictTemplates enabled app-wide with all fallout fixed at root cause, 42 `$safeNavigationMigration` wrappers and 119 tsconfig diagnostic suppressions removed, reportProgress migrated, nx.json cache inputs corrected, `paramsInheritanceStrategy` audit came back clean. Follow-ups tracked in #663 (quiz review endpoint) and #664 (root typecheck). Note: the `e2e-anonymous` CI failures on the merge run are a pre-existing backend outage (`/api/sponsor/profiles` and `/api/geography/travel-stats` returning 500 — same failure on pre-merge master run 8902), tracked separately. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#662