spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

spikersoft-angular: root pnpm typecheck (tsc --noEmit) has ~9,200 pre-existing errors — unusable as a gate #664

New Issue
Closed
opened 2026-07-17 16:19:05 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 16:19:05 +00:00
Owner
Copy Link
Copy Source

Discovered during #662 verification: pnpm run typecheck at the repo root produces 9,227 errors on clean master (spec files missing vitest global types, etc. — the root tsconfig sweeps in files whose type environments live in per-project tsconfigs). It has clearly not been part of any gate for a long time.

Options: scope the root typecheck to non-spec sources, replace it with nx run-many -t typecheck using per-project configs, or delete the script so nobody trusts it. Related to the CI coverage-gap theme (tests.yml path filters).

Discovered during #662 verification: `pnpm run typecheck` at the repo root produces 9,227 errors on clean master (spec files missing vitest global types, etc. — the root tsconfig sweeps in files whose type environments live in per-project tsconfigs). It has clearly not been part of any gate for a long time. Options: scope the root typecheck to non-spec sources, replace it with `nx run-many -t typecheck` using per-project configs, or delete the script so nobody trusts it. Related to the CI coverage-gap theme (tests.yml path filters).
spikerj commented 2026-07-20 04:32:48 +00:00
Author
Owner
Copy Link
Copy Source

Resolved and merged to master. Closing.

  • spikerj/spikersoft-angular#433 — E2a local workspace plugin, adds per-project typecheck targets (merge commit 4996281693a4, merged 2026-07-19, fixes #664).

Took option 2 from the issue: the broken root tsc --noEmit script is gone, replaced on master by typecheck:all → nx run-many -t typecheck --parallel=2, which uses each project's own tsconfig (so spec files get their vitest globals). No more ~9,200 phantom errors from the root sweep. Stayed open only because the cross-repo merge doesn't auto-close tracker issues.

Resolved and merged to `master`. Closing. - spikerj/spikersoft-angular#433 — E2a local workspace plugin, adds per-project `typecheck` targets (merge commit `4996281693a4`, merged 2026-07-19, `fixes #664`). Took option 2 from the issue: the broken root `tsc --noEmit` script is gone, replaced on `master` by `typecheck:all` → `nx run-many -t typecheck --parallel=2`, which uses each project's own tsconfig (so spec files get their vitest globals). No more ~9,200 phantom errors from the root sweep. Stayed open only because the cross-repo merge doesn't auto-close tracker issues.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#664