spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove dead SpaceZone combat-damage duplicates (superseded by SpaceCombatSystem, S1144) #675

New Issue
Closed
opened 2026-07-17 18:50:59 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 18:50:59 +00:00
Owner
Copy Link
Copy Source

Found via S1144 (unused private member) triage. SpaceZone had private ApplyDamageToShip / ApplyDamageToSpacecraft methods that are never called — dead duplicates left over from a refactor.

The LIVE combat damage path is SpaceCombatSystem.ApplyDamageToShip/ApplyDamageToSpacecraft (public, invoked from SpaceCombatSystem's projectile-hit handling, covered by SpaceCombatSystemBroadcastTests and benchmarks). The SpaceZone private copies were superseded and orphaned.

Why it matters: two implementations of the same combat logic is a maintenance hazard — a developer could edit the dead SpaceZone copy expecting it to take effect (it never runs), a silent no-op bug. Confirmed the methods are unreferenced and removing them leaves the GameServer + GameServer.Tests building clean (their helpers — GetDamageMultiplier/GetDefaultHullResistance/GetFirstFunctionalModule — belong to other types and are still used by live SpaceZone code, so no cascade).

Removed the two dead methods (~160 lines). No behavior change (they never executed). SonarQube rule csharpsquid:S1144.

Found via S1144 (unused private member) triage. SpaceZone had private ApplyDamageToShip / ApplyDamageToSpacecraft methods that are never called — dead duplicates left over from a refactor. The LIVE combat damage path is SpaceCombatSystem.ApplyDamageToShip/ApplyDamageToSpacecraft (public, invoked from SpaceCombatSystem's projectile-hit handling, covered by SpaceCombatSystemBroadcastTests and benchmarks). The SpaceZone private copies were superseded and orphaned. **Why it matters:** two implementations of the same combat logic is a maintenance hazard — a developer could edit the dead SpaceZone copy expecting it to take effect (it never runs), a silent no-op bug. Confirmed the methods are unreferenced and removing them leaves the GameServer + GameServer.Tests building clean (their helpers — GetDamageMultiplier/GetDefaultHullResistance/GetFirstFunctionalModule — belong to other types and are still used by live SpaceZone code, so no cascade). Removed the two dead methods (~160 lines). No behavior change (they never executed). SonarQube rule csharpsquid:S1144.
spikerj commented 2026-07-17 18:57:27 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #375 (merged to master). Removed the dead SpaceZone ApplyDamageToShip/ApplyDamageToSpacecraft duplicates (live path is SpaceCombatSystem); ~160 lines, no behavior change. Closing.

Resolved in spikersoft-backend PR #375 (merged to master). Removed the dead SpaceZone ApplyDamageToShip/ApplyDamageToSpacecraft duplicates (live path is SpaceCombatSystem); ~160 lines, no behavior change. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#675