spikerj/spikersoft-issues
1
0
Fork 0
Code Issues 196 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove dead SpaceZone methods (CreateTestSpacecraft, GetDockedChainExcluding) (S1144) #679

New Issue
Closed
opened 2026-07-17 19:36:22 +00:00 by spikerj · 1 comment
spikerj commented 2026-07-17 19:36:22 +00:00
Owner
Copy Link
Copy Source

Found via S1144 (unused private member) triage — continuation of #675.

Two more orphaned SpaceZone methods with no live callers:

  • CreateTestSpacecraft() (~137 lines): only call was commented out when spacecraft moved to inventory-based deployment. Helpers (PreCreateSpacecraftControllers/InitializeSpacecraftThrusters) still used by the live spawn path → no cascade. The identically-named PathManagerTests helper is a separate method, untouched.
  • GetDockedChainExcluding() (9 lines): self-labelled 'Legacy method for backward compatibility', superseded by GetDockedChainExcludingInPlace (live); no callers.

146 dead lines removed; GameServer + GameServer.Tests build clean; no behavior change. SonarQube rule csharpsquid:S1144.

Found via S1144 (unused private member) triage — continuation of #675. Two more orphaned SpaceZone methods with no live callers: - `CreateTestSpacecraft()` (~137 lines): only call was commented out when spacecraft moved to inventory-based deployment. Helpers (PreCreateSpacecraftControllers/InitializeSpacecraftThrusters) still used by the live spawn path → no cascade. The identically-named PathManagerTests helper is a separate method, untouched. - `GetDockedChainExcluding()` (9 lines): self-labelled 'Legacy method for backward compatibility', superseded by GetDockedChainExcludingInPlace (live); no callers. 146 dead lines removed; GameServer + GameServer.Tests build clean; no behavior change. SonarQube rule csharpsquid:S1144.
spikerj commented 2026-07-17 19:52:08 +00:00
Author
Owner
Copy Link
Copy Source

Resolved in spikersoft-backend PR #377 (merged to master). Removed dead SpaceZone CreateTestSpacecraft + GetDockedChainExcluding methods (~146 lines); no behavior change. Closing.

Resolved in spikersoft-backend PR #377 (merged to master). Removed dead SpaceZone CreateTestSpacecraft + GetDockedChainExcluding methods (~146 lines); no behavior change. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agentic
Actionable surfaced by the agentic architecture & security review
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 sonarqube
Code quality issue surfaced by SonarQube (bug / code smell)
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
spikerj (Joseph Spiker)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#679