Angular master CI red: Stylelint declaration-empty-line-before in sponsor-family.component.scss #817

New Issue

2026-07-23T15:29:49Z

spikerj commented

2026-07-23 15:29:49 +00:00

Symptom

test-and-lint job fails on master (run 17759, step Run Lint (full — pushes)):

projects/spikersoft/src/app/_components/sponsor-family/sponsor-family.component.scss
   33:2  ✖  Expected empty line before declaration  declaration-empty-line-before
   81:2  ✖  Expected empty line before declaration  declaration-empty-line-before
  114:2  ✖  Expected empty line before declaration  declaration-empty-line-before
  366:2  ✖  Expected empty line before declaration  declaration-empty-line-before
✖ 4 problems (4 errors, 0 warnings)

Cause

The sponsor-family component SCSS was pushed without running pnpm run lint:styles:fix (AGENTS.md non-negotiable #1). All 4 are the same rule: a declaration immediately following an @include glass-themed(...) needs a blank line before it. The pre-commit hook formats staged files but does not run Stylelint, so SCSS rule violations slip through to CI — exactly the case the run-lint-fixers-before-push rule warns about.

Fix

stylelint --fix on the file (4 blank-line insertions). Full pnpm run lint:styles then passes clean.

## Symptom `test-and-lint` job fails on master (run [17759](https://git.spikersoft.com/spikerj/spikersoft-angular/actions/runs/17759/jobs/68573), step *Run Lint (full — pushes)*): ``` projects/spikersoft/src/app/_components/sponsor-family/sponsor-family.component.scss 33:2 ✖ Expected empty line before declaration declaration-empty-line-before 81:2 ✖ Expected empty line before declaration declaration-empty-line-before 114:2 ✖ Expected empty line before declaration declaration-empty-line-before 366:2 ✖ Expected empty line before declaration declaration-empty-line-before ✖ 4 problems (4 errors, 0 warnings) ``` ## Cause The sponsor-family component SCSS was pushed without running `pnpm run lint:styles:fix` (AGENTS.md non-negotiable #1). All 4 are the same rule: a declaration immediately following an `@include glass-themed(...)` needs a blank line before it. The pre-commit hook formats staged files but does **not** run Stylelint, so SCSS rule violations slip through to CI — exactly the case the `run-lint-fixers-before-push` rule warns about. ## Fix `stylelint --fix` on the file (4 blank-line insertions). Full `pnpm run lint:styles` then passes clean.

spikerj referenced this issue

2026-07-23 15:55:18 +00:00

Angular lint: COVERAGE-LOOP.md trips `prettier -c .` on master #818

spikerj commented

2026-07-24 18:59:24 +00:00

Fixed and verified. spikersoft-angular PR #554 (`e1e00eb6`, merged to master) added the blank line before the declarations following `@include` in `sponsor-family.component.scss`.

Verified on master today: `npx stylelint projects/spikersoft/src/app/_components/sponsor-family/sponsor-family.component.scss` exits 0 with no output, and `test-and-lint` is green on the latest master run (18120). Closing.

— Opus 5 Agent

Fixed and verified. spikersoft-angular PR #554 (\`e1e00eb6\`, merged to master) added the blank line before the declarations following \`@include\` in \`sponsor-family.component.scss\`. Verified on master today: \`npx stylelint projects/spikersoft/src/app/_components/sponsor-family/sponsor-family.component.scss\` exits 0 with no output, and \`test-and-lint\` is green on the latest master run (18120). Closing. — Opus 5 Agent

spikerj closed this issue

2026-07-24 18:59:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: spikerj/spikersoft-issues#817