spikerj commented on issue spikerj/spikersoft-issues#633 2026-07-17 05:50:06 +00:00
[Go-Live Checklist][Security] Rotate + Bao-migrate the dev-environment secrets before production

Closure audit (2026-07-17 05:50): all 37 still-open SonarQube vulnerabilities on the backend are accounted for — none unexamined. 13 are stale SpikerSoft.Api/appsettings.json lines whose secrets…

spikerj opened issue spikerj/spikersoft-issues#641 2026-07-17 05:41:12 +00:00
[Backend] S1172 unused-parameter family (74, incl. 28 unused CancellationTokens): rubric batch after the #632 baseline lands
spikerj opened issue spikerj/spikersoft-issues#640 2026-07-17 05:38:52 +00:00
[GameServer][Bug] Four command types were never ClientTick/Sequence-stamped on deserialization — the per-type stamp switch silently skipped them (found via SonarQube S1871)
spikerj commented on issue spikerj/spikersoft-issues#638 2026-07-17 05:31:06 +00:00
[Backend] Detector/rule-engine override parameters renamed to match their base declarations (SonarQube S927 x14) + proposal: drop CA1873/CA1861 imports from sonar (56% of all open issues)

Adding a third noise-family to the proposal from continued triage: S1075 'hardcoded URIs/paths' (74 findings). Sampled sites are dominated by deliberate constants — /var/run/docker.sock in…

spikerj opened issue spikerj/spikersoft-issues#639 2026-07-17 05:26:38 +00:00
[Backend] Telemetry-fidelity log-call family: S6667 (83) + S2139 (187) need per-site triage with a rubric, not bulk treatment
spikerj closed issue spikerj/spikersoft-issues#637 2026-07-17 05:23:14 +00:00
[Backend] Minor-bug batch from SonarQube triage: freeze the remediation allowlist + spell registry, constrain generic event handlers, dead null-coalesce, poll-loop default cases
spikerj closed issue spikerj/spikersoft-issues#635 2026-07-17 05:23:13 +00:00
[Backend] Duplicate placeholder names in structured-log templates render unbound holes and collide in Seq (SonarQube S6677 x3)
spikerj commented on issue spikerj/spikersoft-issues#636 2026-07-17 05:23:13 +00:00
[Backend][Tests] Five strict-mock tests carry no explicit assertion (SonarQube S2699 BLOCKER x6 — 5 fixed, 1 false-positived)

Resolved in spikersoft-backend PR #343 (merged to master). The five strict-mock tests now assert their never-called contract explicitly via VerifyNoOtherCalls(); the sixth S2699 finding (EnglishSou…

spikerj closed issue spikerj/spikersoft-issues#636 2026-07-17 05:23:13 +00:00
[Backend][Tests] Five strict-mock tests carry no explicit assertion (SonarQube S2699 BLOCKER x6 — 5 fixed, 1 false-positived)
spikerj commented on issue spikerj/spikersoft-issues#637 2026-07-17 05:23:13 +00:00
[Backend] Minor-bug batch from SonarQube triage: freeze the remediation allowlist + spell registry, constrain generic event handlers, dead null-coalesce, poll-loop default cases

Resolved in spikersoft-backend PR #344 (merged to master). RemediationActions.SafeSet (the host auto-remediation allowlist) and SpellDefinitions.Spells are frozen collections now; GameEventsConsume…

spikerj commented on issue spikerj/spikersoft-issues#635 2026-07-17 05:23:11 +00:00
[Backend] Duplicate placeholder names in structured-log templates render unbound holes and collide in Seq (SonarQube S6677 x3)

Resolved in spikersoft-backend PR #342 (merged to master). The three S6677 duplicate-placeholder templates are reworded (unbound holes no longer render literally in the Python-probe and art_pipe…

spikerj opened issue spikerj/spikersoft-issues#638 2026-07-17 05:20:02 +00:00
[Backend] Detector/rule-engine override parameters renamed to match their base declarations (SonarQube S927 x14) + proposal: drop CA1873/CA1861 imports from sonar (56% of all open issues)
spikerj commented on issue spikerj/spikersoft-issues#632 2026-07-17 05:18:45 +00:00
[CI][Backend] sonar-scan has uploaded nothing since 2026-07-14 — scanner gets a wrong SonarQube host and continue-on-error hides the failure

PR #341 got merged after commit 1 only (the host pin + unmasking); the LLama-test exclusion and master-only-trigger commits missed that merge. Re-landed via PR #345 (merged). The post-merge master…

spikerj closed issue spikerj/spikersoft-issues#631 2026-07-17 05:17:42 +00:00
[Reader][Social] Backend: shared bookmarks, upvotes, and reading lists (opt-in, child-safe)
spikerj closed issue spikerj/spikersoft-issues#634 2026-07-17 05:17:42 +00:00
[Reader][Social] Frontend: profile Social tab, reader Community tab, upvotes, reading-list dialog
spikerj commented on issue spikerj/spikersoft-issues#634 2026-07-17 05:17:37 +00:00
[Reader][Social] Frontend: profile Social tab, reader Community tab, upvotes, reading-list dialog

Resolved in spikersoft-angular PR #221 (merged to master). Full social reading frontend: social models + ReaderService methods, the profile Social tab (hidden for excluded accounts), and the…

spikerj commented on issue spikerj/spikersoft-issues#631 2026-07-17 05:17:34 +00:00
[Reader][Social] Backend: shared bookmarks, upvotes, and reading lists (opt-in, child-safe)

Resolved in spikersoft-backend PR #340 (merged to master, 360828c). Social reading backend: ProfileSocial opt-ins, the ISocialVisibilityService choke point (child/minor hard-excluded via…

spikerj commented on issue spikerj/spikersoft-issues#632 2026-07-17 05:13:15 +00:00
[CI][Backend] sonar-scan has uploaded nothing since 2026-07-14 — scanner gets a wrong SonarQube host and continue-on-error hides the failure

Third commit on PR #341: dropped the pull_request trigger entirely (master push + workflow_dispatch only). Two independent reasons, both verified: (1) Community Edition submits PR-event scans as…

spikerj commented on issue spikerj/spikersoft-issues#637 2026-07-17 05:08:49 +00:00
[Backend] Minor-bug batch from SonarQube triage: freeze the remediation allowlist + spell registry, constrain generic event handlers, dead null-coalesce, poll-loop default cases

Added a 6th item to PR #344: JsonPacketSerializer's S3923 BUG — an if/else whose branches were byte-identical (both set dict["type"] = GetEventTypeName(evt)). Collapsed to one unconditional…

spikerj opened issue spikerj/spikersoft-issues#637 2026-07-17 05:05:51 +00:00
[Backend] Minor-bug batch from SonarQube triage: freeze the remediation allowlist + spell registry, constrain generic event handlers, dead null-coalesce, poll-loop default cases