spikerj commented on issue spikerj/spikersoft-issues#682 2026-07-17 20:10:54 +00:00
perf(mcp): cache CalendarTools JsonSerializerOptions instead of per-call allocation (CA1869)

Resolved in spikersoft-backend PR #380 (merged to master). Hoisted CalendarTools' 4 per-call JsonSerializerOptions to one static readonly instance; no behavior change. Closing.

spikerj opened issue spikerj/spikersoft-issues#682 2026-07-17 20:07:27 +00:00
perf(mcp): cache CalendarTools JsonSerializerOptions instead of per-call allocation (CA1869)
spikerj closed issue spikerj/spikersoft-issues#681 2026-07-17 20:05:28 +00:00
perf(keycloak): cache JsonSerializerOptions instead of per-call allocation (CA1869)
spikerj commented on issue spikerj/spikersoft-issues#681 2026-07-17 20:05:28 +00:00
perf(keycloak): cache JsonSerializerOptions instead of per-call allocation (CA1869)

Resolved in spikersoft-backend PR #379 (merged to master). Hoisted KeycloakAdminService's 4 per-call JsonSerializerOptions to 2 static readonly instances; all 41 tests pass. Closing.

spikerj opened issue spikerj/spikersoft-issues#681 2026-07-17 20:04:18 +00:00
perf(keycloak): cache JsonSerializerOptions instead of per-call allocation (CA1869)
spikerj opened issue spikerj/spikersoft-issues#680 2026-07-17 19:58:27 +00:00
refactor(3dmodel): consolidate duplicated auth checks into TryGetUserId helper (S1192)
spikerj commented on issue spikerj/spikersoft-issues#677 2026-07-17 19:52:08 +00:00
refactor(artstudio): consolidate 27 duplicated token-user-id auth checks into a helper (S1192)

Resolved in spikersoft-backend PR #376 (merged to master). Consolidated the 27 duplicated token-user-id auth checks into a TryGetUserId helper; behavior identical, all 49 controller tests pass.…

spikerj closed issue spikerj/spikersoft-issues#677 2026-07-17 19:52:08 +00:00
refactor(artstudio): consolidate 27 duplicated token-user-id auth checks into a helper (S1192)
spikerj commented on issue spikerj/spikersoft-issues#679 2026-07-17 19:52:08 +00:00
chore: remove dead SpaceZone methods (CreateTestSpacecraft, GetDockedChainExcluding) (S1144)

Resolved in spikersoft-backend PR #377 (merged to master). Removed dead SpaceZone CreateTestSpacecraft + GetDockedChainExcluding methods (~146 lines); no behavior change. Closing.

spikerj closed issue spikerj/spikersoft-issues#679 2026-07-17 19:52:08 +00:00
chore: remove dead SpaceZone methods (CreateTestSpacecraft, GetDockedChainExcluding) (S1144)
spikerj opened issue spikerj/spikersoft-issues#679 2026-07-17 19:36:22 +00:00
chore: remove dead SpaceZone methods (CreateTestSpacecraft, GetDockedChainExcluding) (S1144)
spikerj opened issue spikerj/spikersoft-issues#678 2026-07-17 19:29:41 +00:00
CleanupOrphanData loads allUploadIds but never uses it — possible missing orphan-scan case (S1481)
spikerj opened issue spikerj/spikersoft-issues#677 2026-07-17 19:24:48 +00:00
refactor(artstudio): consolidate 27 duplicated token-user-id auth checks into a helper (S1192)
spikerj opened issue spikerj/spikersoft-issues#676 2026-07-17 19:05:54 +00:00
Background-check + Keycloak base URLs hardcoded to production (no sandbox config) — S1075
spikerj closed issue spikerj/spikersoft-issues#675 2026-07-17 18:57:27 +00:00
chore: remove dead SpaceZone combat-damage duplicates (superseded by SpaceCombatSystem, S1144)
spikerj commented on issue spikerj/spikersoft-issues#675 2026-07-17 18:57:27 +00:00
chore: remove dead SpaceZone combat-damage duplicates (superseded by SpaceCombatSystem, S1144)

Resolved in spikersoft-backend PR #375 (merged to master). Removed the dead SpaceZone ApplyDamageToShip/ApplyDamageToSpacecraft duplicates (live path is SpaceCombatSystem); ~160 lines, no behavior…

spikerj opened issue spikerj/spikersoft-issues#675 2026-07-17 18:50:59 +00:00
chore: remove dead SpaceZone combat-damage duplicates (superseded by SpaceCombatSystem, S1144)
spikerj commented on issue spikerj/spikersoft-issues#673 2026-07-17 18:40:09 +00:00
CurriculumPythonInterpreter throws ArgumentNullException on unparseable Python version (CS8604)

Resolved in spikersoft-backend PR #372 (merged to master). Captured the ParseVersion result and null-guarded it before MeetsMinimum at both sites, so an unparseable Python version banner no longer…

spikerj commented on issue spikerj/spikersoft-issues#674 2026-07-17 18:40:09 +00:00
Security: blog body sanitization uses bypassable regex (stored XSS) — replace with HtmlSanitizer

Resolved in spikersoft-backend PR #373 (merged to master, reviewed by spikerj). Replaced the bypassable regex blog-body sanitization with the allowlist/DOM-based HtmlSanitizer (Ganss.Xss 9.0.892),…

spikerj closed issue spikerj/spikersoft-issues#674 2026-07-17 18:39:55 +00:00
Security: blog body sanitization uses bypassable regex (stored XSS) — replace with HtmlSanitizer